Change in ...coreboot[master]: coreboot: add post code for SoC initialization failure

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32774 )

Change subject: coreboot: add post code for SoC initialization failure
......................................................................

Patch Set 2:

(3 comments)

https://review.coreboot.org/#/c/32774/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/32774/2//COMMIT_MSG@10 
PS2, Line 10: integratred
integrated.

https://review.coreboot.org/#/c/32774/2/src/include/console/post_codes.h 
File src/include/console/post_codes.h:

https://review.coreboot.org/#/c/32774/2/src/include/console/post_codes.h@356 
PS2, Line 356: POST_SOC_FAILURE
Why is this just for SOCs?  Wouldn't those same components be somewhere else like the southbridge in a Non-SOC system?

Maybe make it more generic - POST_INIT_FAILURE?

https://review.coreboot.org/#/c/32774/2/src/soc/intel/quark/i2c.c 
File src/soc/intel/quark/i2c.c:

https://review.coreboot.org/#/c/32774/2/src/soc/intel/quark/i2c.c@42 
PS2, Line 42: die("ERROR - I2C failed to disable!\n");
Only somewhat related to the overall patch, but is it really appropriate to halt the system because an I2C device didn't disable properly?