Attention is currently required from: Lance Zhao, Tim Wawrzynczak, Arthur Heymans.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63414 )
Change subject: lib/hardwaremain.c: Move creating ACPI structs to bootstate hooks
......................................................................
Patch Set 3:
(3 comments)
File src/acpi/gnvs.c:
https://review.coreboot.org/c/coreboot/+/63414/comment/9a737018_f3cb7883
PS1, Line 18: return;
Not needed […]
Done
File src/lib/hardwaremain.c:
https://review.coreboot.org/c/coreboot/+/63414/comment/3bd422c1_3b5f23e4
PS1, Line 27: #include <vendorcode/google/chromeos/chromeos.h>
Probably not needed.
Done
File src/vendorcode/google/chromeos/gnvs.c:
https://review.coreboot.org/c/coreboot/+/63414/comment/2292ff94_f463daee
PS1, Line 35: void chromeos_init_chromeos_acpi(void *unused)
static void ...
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63414
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I613b927b9a193fc076ffb1b2a40c617965ce2645
Gerrit-Change-Number: 63414
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 07 Apr 2022 07:20:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment