Steve Mooney has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25439 )
Change subject: soc/intel/denverton_ns: Initialize thermal configuration
......................................................................
Patch Set 13: Code-Review-1
(1 comment)
One bug to fix. The rest looks good.
https://review.coreboot.org/#/c/25439/13/src/soc/intel/denverton_ns/cpu.c
File src/soc/intel/denverton_ns/cpu.c:
https://review.coreboot.org/#/c/25439/13/src/soc/intel/denverton_ns/cpu.c@82
PS13, Line 82: msr.lo &= (1 << 3); /* Clear TM enable */
Need to add ~ to clear the targeted bit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/25439
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7e1b924154256f8f82ded3d0fa155b3e836d9375
Gerrit-Change-Number: 25439
Gerrit-PatchSet: 13
Gerrit-Owner: Julien Viard de Galbert
coreboot-review-ju@vdg.name
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Julien Viard de Galbert
coreboot-review-ju@vdg.name
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Steve Mooney
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Comment-Date: Fri, 31 May 2019 15:26:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment