Attention is currently required from: Anil Kumar K, Arthur Heymans, Bora Guvendik, Cliff Huang, Jamie Ryu, Jérémy Compostella, Kane Chen, Karthik Ramasubramanian, Krishna P Bhat D, Pratikkumar V Prajapati, Ravishankar Sarawadi, Ronak Kanabar, Subrata Banik, V Sowmya, Wonkyu Kim.
Gaggery Tsai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77904?usp=email )
Change subject: src/soc/intel/common: Add Intel RMT+ support
......................................................................
Patch Set 8:
(3 comments)
File src/soc/intel/common/block/memory/Kconfig:
https://review.coreboot.org/c/coreboot/+/77904/comment/ed30f586_26745ce0 :
PS7, Line 33: depends on VBOOT
Needs it to query boot mode. […]
Done
File src/soc/intel/common/block/memory/meminit.c:
https://review.coreboot.org/c/coreboot/+/77904/comment/cee45507_8ed95680 :
PS7, Line 221: __weak void enable_rmt_plus_platform(FSP_M_CONFIG *mem_cfg)
: {
: printk(BIOS_DEBUG, "RMT+ is not supported.\n");
: }
I will revise it.
Done
https://review.coreboot.org/c/coreboot/+/77904/comment/2154ba86_75187dc4 :
PS7, Line 228: vboot_developer_mode_enabled()
Only enables this RMT+ feature with DEV mode since it will increase about 8% of boot time. […]
Added another flag for DEV mode.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77904?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I03df4d0a927caa101da3db078b268dcdb4e78550
Gerrit-Change-Number: 77904
Gerrit-PatchSet: 8
Gerrit-Owner: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Sun, 24 Mar 2024 18:55:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Gaggery Tsai
gaggery.tsai@intel.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment