Attention is currently required from: Tim Wawrzynczak, Jingle Hsu, Subrata Banik, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58576 )
Change subject: soc/intel/common: Add DDR5 and LPDDR5 into the SMBIOS table
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/common/smbios.c:
https://review.coreboot.org/c/coreboot/+/58576/comment/178d6d03_76c2d48b
PS1, Line 84: dimm->bus_width |= 0x10;
That's what it appeared to me when I was referring the SPD spec for DDR5 and LP5 […]
OK, I just had a look at the code. The `bus_width` field uses the SMBIOS encoding. The original `0x8` corresponds to the `BIOS_MEMORY_ECC_SINGLE_BIT_CORRECTING` macro. `0x10` corresponds to the `BIOS_MEMORY_ECC_DOUBLE_BIT_CORRECTING` macro. This doesn't need to be changed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58576
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ec442cf0bd830db99e3636445724b6be01c5564
Gerrit-Change-Number: 58576
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 25 Oct 2021 20:08:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment