EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37319 )
Change subject: soc/intel/cannonlake: Ensure bootblock disable GPIO PM configuration
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37319/2/src/soc/intel/cannonlake/bo...
File src/soc/intel/cannonlake/bootblock/pch.c:
https://review.coreboot.org/c/coreboot/+/37319/2/src/soc/intel/cannonlake/bo...
PS2, Line 186: soc_fill_gpio_pm_configuration
valid point, let me address this
Agree with Furquan, this is why I said we should invoke this right after FSP-S....
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37319
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54061d556d62462d9012bc47bb9f3604a3e5a250
Gerrit-Change-Number: 37319
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 02 Dec 2019 05:39:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment