Akash Asthana has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25372 )
Change subject: sdm845: Add QUPv3 FW load & config
......................................................................
Patch Set 63:
(1 comment)
https://review.coreboot.org/#/c/25372/6/src/mainboard/google/cheza/qupv3_con...
File src/mainboard/google/cheza/qupv3_config.c:
https://review.coreboot.org/#/c/25372/6/src/mainboard/google/cheza/qupv3_con...
PS6, Line 18: struct se_cfg se_mappings[QUPV3_SE_MAX] =
Is the loading of FW from respective protocol init function is needed for OTA upgrade OR something […]
Okay, We are planning to load QUPV3 firmware from respective driver init function. Can you please share some reference driver for the same if any exists ?
And if we load FW from respective driver init function then how should we handle the use cases that are only present in HLOS, like fingerprint SPI etc. Should we call respective instance driver init function from ramstage? So that will load FW and configure the required QUP.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/25372
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e87f868ecbe2a8e51d94c045ad76b99bb1b345d
Gerrit-Change-Number: 25372
Gerrit-PatchSet: 63
Gerrit-Owner: T.Michael Turney
tturne@codeaurora.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mukesh Savaliya
msavaliy@qualcomm.corp-partner.google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: T.Michael Turney
tturne@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Akash Asthana
akashast@qualcomm.corp-partner.google.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Mon, 21 Jan 2019 13:14:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Akash Asthana
akashast@qualcomm.corp-partner.google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment