Change in coreboot[master]: acpi: Update sata files to be more aligned with rest of acpi files
Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40933 )
Change subject: acpi: Update sata files to be more aligned with rest of acpi files ......................................................................
acpi: Update sata files to be more aligned with rest of acpi files
This change renames sata.c to acpi_sata.c and moves sata.h to include/acpi/acpi_sata.h to align them with the rest of the files under acpi/.
BUG=b:155428745
Change-Id: I3f97e5c12535a331d7347c0ecad00b07b5f13f37 Signed-off-by: Furquan Shaikh furquan@google.com --- M src/acpi/Makefile.inc R src/acpi/acpi_sata.c R src/include/acpi/acpi_sata.h M src/southbridge/intel/bd82x6x/sata.c M src/southbridge/intel/ibexpeak/sata.c 5 files changed, 4 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/40933/1
diff --git a/src/acpi/Makefile.inc b/src/acpi/Makefile.inc index 0010fea..d311278 100644 --- a/src/acpi/Makefile.inc +++ b/src/acpi/Makefile.inc @@ -6,12 +6,11 @@ ramstage-y += acpi.c ramstage-y += acpi_device.c ramstage-y += acpi_pld.c +ramstage-y += acpi_sata.c ramstage-y += acpigen.c ramstage-y += acpigen_dsm.c ramstage-y += acpigen_ps2_keybd.c
-ramstage-y += sata.c - ifneq ($(wildcard src/mainboard/$(MAINBOARDDIR)/acpi_tables.c),) ramstage-srcs += src/mainboard/$(MAINBOARDDIR)/acpi_tables.c endif diff --git a/src/acpi/sata.c b/src/acpi/acpi_sata.c similarity index 97% rename from src/acpi/sata.c rename to src/acpi/acpi_sata.c index f2f53e6..110742e 100644 --- a/src/acpi/sata.c +++ b/src/acpi/acpi_sata.c @@ -1,10 +1,9 @@ /* SPDX-License-Identifier: GPL-2.0-only */ /* This file is part of the coreboot project. */
-#include "sata.h" - #include <acpi/acpi.h> #include <acpi/acpigen.h> +#include <acpi/acpi_sata.h>
/* e.g. * generate_sata_ssdt_ports("_SB.PCI0.SATA", 0x3); diff --git a/src/acpi/sata.h b/src/include/acpi/acpi_sata.h similarity index 100% rename from src/acpi/sata.h rename to src/include/acpi/acpi_sata.h diff --git a/src/southbridge/intel/bd82x6x/sata.c b/src/southbridge/intel/bd82x6x/sata.c index e65fd6e..57eb7e7 100644 --- a/src/southbridge/intel/bd82x6x/sata.c +++ b/src/southbridge/intel/bd82x6x/sata.c @@ -8,7 +8,7 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <option.h> -#include <acpi/sata.h> +#include <acpi/acpi_sata.h> #include <types.h>
#include "chip.h" diff --git a/src/southbridge/intel/ibexpeak/sata.c b/src/southbridge/intel/ibexpeak/sata.c index 11ac078..df13989 100644 --- a/src/southbridge/intel/ibexpeak/sata.c +++ b/src/southbridge/intel/ibexpeak/sata.c @@ -8,7 +8,7 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <option.h> -#include <acpi/sata.h> +#include <acpi/acpi_sata.h> #include <types.h>
#include "chip.h"
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40933
to look at the new patch set (#4).
Change subject: acpi: Update sata files to be more aligned with rest of acpi files ......................................................................
acpi: Update sata files to be more aligned with rest of acpi files
This change renames sata.c to acpi_sata.c and moves sata.h to include/acpi/acpi_sata.h to align them with the rest of the files under acpi/.
BUG=b:155428745
Change-Id: I3f97e5c12535a331d7347c0ecad00b07b5f13f37 Signed-off-by: Furquan Shaikh furquan@google.com --- M src/acpi/Makefile.inc R src/acpi/acpi_sata.c R src/include/acpi/acpi_sata.h M src/southbridge/intel/bd82x6x/sata.c M src/southbridge/intel/ibexpeak/sata.c 5 files changed, 4 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/40933/4
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40933 )
Change subject: acpi: Update sata files to be more aligned with rest of acpi files ......................................................................
Patch Set 5: Code-Review+1
do we want files named under 'acpi' directory with acpi_ prefix? Is it redundant? I get the header file argument, but does the c file naming need to be like that? Thinking out loud, fwiw.
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Aaron Durbin, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40933
to look at the new patch set (#7).
Change subject: acpi: Update sata files to be more aligned with rest of acpi files ......................................................................
acpi: Update sata files to be more aligned with rest of acpi files
This change renames sata.c to acpi_sata.c and moves sata.h to include/acpi/acpi_sata.h to align them with the rest of the files under acpi/.
BUG=b:155428745
Change-Id: I3f97e5c12535a331d7347c0ecad00b07b5f13f37 Signed-off-by: Furquan Shaikh furquan@google.com --- M src/acpi/Makefile.inc R src/acpi/acpi_sata.c R src/include/acpi/acpi_sata.h M src/southbridge/intel/bd82x6x/sata.c M src/southbridge/intel/ibexpeak/sata.c 5 files changed, 4 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/40933/7
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40933 )
Change subject: acpi: Update sata files to be more aligned with rest of acpi files ......................................................................
Patch Set 8:
Patch Set 5: Code-Review+1
do we want files named under 'acpi' directory with acpi_ prefix? Is it redundant? I get the header file argument, but does the c file naming need to be like that? Thinking out loud, fwiw.
Makes sense.. i can go the other way.
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Aaron Durbin, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40933
to look at the new patch set (#9).
Change subject: acpi: Update sata files to be more aligned with rest of acpi files ......................................................................
acpi: Update sata files to be more aligned with rest of acpi files
This change moves sata.h to include/acpi/acpi_sata.h to align with the rest of the acpi header files in include/acpi.
BUG=b:155428745
Change-Id: I3f97e5c12535a331d7347c0ecad00b07b5f13f37 Signed-off-by: Furquan Shaikh furquan@google.com --- M src/acpi/sata.c R src/include/acpi/acpi_sata.h M src/southbridge/intel/bd82x6x/sata.c M src/southbridge/intel/ibexpeak/sata.c 4 files changed, 3 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/40933/9
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40933 )
Change subject: acpi: Update sata files to be more aligned with rest of acpi files ......................................................................
Patch Set 9: Code-Review+2
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40933 )
Change subject: acpi: Update sata files to be more aligned with rest of acpi files ......................................................................
Patch Set 9: Code-Review+2
Patch Set 8:
Patch Set 5: Code-Review+1
do we want files named under 'acpi' directory with acpi_ prefix? Is it redundant? I get the header file argument, but does the c file naming need to be like that? Thinking out loud, fwiw.
Makes sense.. i can go the other way.
I would drop it on headers too, but that is a pain..
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40933 )
Change subject: acpi: Update sata files to be more aligned with rest of acpi files ......................................................................
Patch Set 11: Code-Review+2
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40933 )
Change subject: acpi: Update sata files to be more aligned with rest of acpi files ......................................................................
acpi: Update sata files to be more aligned with rest of acpi files
This change moves sata.h to include/acpi/acpi_sata.h to align with the rest of the acpi header files in include/acpi.
BUG=b:155428745
Change-Id: I3f97e5c12535a331d7347c0ecad00b07b5f13f37 Signed-off-by: Furquan Shaikh furquan@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40933 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Duncan Laurie dlaurie@chromium.org --- M src/acpi/sata.c R src/include/acpi/acpi_sata.h M src/southbridge/intel/bd82x6x/sata.c M src/southbridge/intel/ibexpeak/sata.c 4 files changed, 3 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved Aaron Durbin: Looks good to me, approved HAOUAS Elyes: Looks good to me, approved
diff --git a/src/acpi/sata.c b/src/acpi/sata.c index f2f53e6..110742e 100644 --- a/src/acpi/sata.c +++ b/src/acpi/sata.c @@ -1,10 +1,9 @@ /* SPDX-License-Identifier: GPL-2.0-only */ /* This file is part of the coreboot project. */
-#include "sata.h" - #include <acpi/acpi.h> #include <acpi/acpigen.h> +#include <acpi/acpi_sata.h>
/* e.g. * generate_sata_ssdt_ports("_SB.PCI0.SATA", 0x3); diff --git a/src/acpi/sata.h b/src/include/acpi/acpi_sata.h similarity index 100% rename from src/acpi/sata.h rename to src/include/acpi/acpi_sata.h diff --git a/src/southbridge/intel/bd82x6x/sata.c b/src/southbridge/intel/bd82x6x/sata.c index e65fd6e..57eb7e7 100644 --- a/src/southbridge/intel/bd82x6x/sata.c +++ b/src/southbridge/intel/bd82x6x/sata.c @@ -8,7 +8,7 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <option.h> -#include <acpi/sata.h> +#include <acpi/acpi_sata.h> #include <types.h>
#include "chip.h" diff --git a/src/southbridge/intel/ibexpeak/sata.c b/src/southbridge/intel/ibexpeak/sata.c index 11ac078..df13989 100644 --- a/src/southbridge/intel/ibexpeak/sata.c +++ b/src/southbridge/intel/ibexpeak/sata.c @@ -8,7 +8,7 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <option.h> -#include <acpi/sata.h> +#include <acpi/acpi_sata.h> #include <types.h>
#include "chip.h"
-
Aaron Durbin (Code Review) -
Duncan Laurie (Code Review)
-
Furquan Shaikh (Code Review)
-
HAOUAS Elyes (Code Review)