Attention is currently required from: Arthur Heymans, Patrick Rudolph. Hello build bot (Jenkins), Nico Huber, Arthur Heymans, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51886
to look at the new patch set (#10).
Change subject: nb/intel/common: Replace `_bar_clrsetbits_impl` macro ......................................................................
nb/intel/common: Replace `_bar_clrsetbits_impl` macro
This macro contains a cast on the and-mask, which can suppress actual type overflow issues. Replace it with wrapper functions around the existing macros in device/mmio.h which still contain a type cast, but it is a non-issue because the wrapper functions now allow compilers to check for overflows.
Change-Id: I975bf8152fc961767f0292bff4a03aecd8c65f56 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/common/fixed_bars.h 1 file changed, 58 insertions(+), 29 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/51886/10