build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47727 )
Change subject: soc/amd/picasso: Generate ACPI CRAT objects in cb ......................................................................
Patch Set 3:
(7 comments)
https://review.coreboot.org/c/coreboot/+/47727/3/src/include/acpi/acpi_crat.... File src/include/acpi/acpi_crat.h:
https://review.coreboot.org/c/coreboot/+/47727/3/src/include/acpi/acpi_crat.... PS3, Line 20: #define CRAT_HSA_PR_FLAG_CPU_PRES_SHFT 2 'PRES' may be misspelled - perhaps 'PRESS'?
https://review.coreboot.org/c/coreboot/+/47727/3/src/include/acpi/acpi_crat.... PS3, Line 21: #define CRAT_HSA_PR_FLAG_CPU_PRES (0x1 << CRAT_HSA_PR_FLAG_CPU_PRES_SHFT) 'PRES' may be misspelled - perhaps 'PRESS'?
https://review.coreboot.org/c/coreboot/+/47727/3/src/include/acpi/acpi_crat.... PS3, Line 21: #define CRAT_HSA_PR_FLAG_CPU_PRES (0x1 << CRAT_HSA_PR_FLAG_CPU_PRES_SHFT) 'PRES' may be misspelled - perhaps 'PRESS'?
https://review.coreboot.org/c/coreboot/+/47727/3/src/include/acpi/acpi_crat.... PS3, Line 22: #define CRAT_HSA_PR_FLAG_GPU_PRES_SHFT 3 'PRES' may be misspelled - perhaps 'PRESS'?
https://review.coreboot.org/c/coreboot/+/47727/3/src/include/acpi/acpi_crat.... PS3, Line 23: #define CRAT_HSA_PR_FLAG_GPU_PRES (0x1 << CRAT_HSA_PR_FLAG_GPU_PRES_SHFT) 'PRES' may be misspelled - perhaps 'PRESS'?
https://review.coreboot.org/c/coreboot/+/47727/3/src/include/acpi/acpi_crat.... PS3, Line 23: #define CRAT_HSA_PR_FLAG_GPU_PRES (0x1 << CRAT_HSA_PR_FLAG_GPU_PRES_SHFT) 'PRES' may be misspelled - perhaps 'PRESS'?
https://review.coreboot.org/c/coreboot/+/47727/3/src/soc/amd/picasso/agesa_a... File src/soc/amd/picasso/agesa_acpi.c:
https://review.coreboot.org/c/coreboot/+/47727/3/src/soc/amd/picasso/agesa_a... PS3, Line 505: hsa_entry->flags = CRAT_HSA_PR_FLAG_EN | CRAT_HSA_PR_FLAG_CPU_PRES; 'PRES' may be misspelled - perhaps 'PRESS'?
-
build bot (Jenkins) (Code Review)