Attention is currently required from: Hung-Te Lin, Paul Menzel, Wentao Qin, Xuxin Xiong, Yang Wu, Yidi Lin.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82089?usp=email )
Change subject: mb/google/corsola/var/wugtrio: Add initialize USB port 0
......................................................................
Patch Set 11:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82089/comment/de0221f0_4c7681fc :
PS11, Line 7: /var/wugtrio
Actually, this patch uses fw_config to decide the initialization, and isn't directly related to a particular variant (wugtrio). Therefore please take `/var/wugtrio` out.
https://review.coreboot.org/c/coreboot/+/82089/comment/a3537da3_d1d17c89 :
PS11, Line 10: option 27th in fwconfig
bit 27 in fw_config
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82089?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I725b80593f5fc498a204bf47f943c36ccbd78134
Gerrit-Change-Number: 82089
Gerrit-PatchSet: 11
Gerrit-Owner: Wentao Qin
qinwentao@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Mingjin Ge
mingjin.ge@mediatek.corp-partner.google.com
Gerrit-Reviewer: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Attention: Wentao Qin
qinwentao@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Tue, 30 Apr 2024 00:34:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment