Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36890 )
Change subject: mb/gigabyte/ga-b75m-d3h: Drop useless function-disable setting ......................................................................
mb/gigabyte/ga-b75m-d3h: Drop useless function-disable setting
This bit is already cleared by a reset.
Change-Id: Ib71496011c9621476a7327ba309f367c7fa971e4 Signed-off-by: Nico Huber nico.h@gmx.de --- M src/mainboard/gigabyte/ga-b75m-d3h/early_init.c 1 file changed, 0 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/36890/1
diff --git a/src/mainboard/gigabyte/ga-b75m-d3h/early_init.c b/src/mainboard/gigabyte/ga-b75m-d3h/early_init.c index 65616ff..265e511 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3h/early_init.c +++ b/src/mainboard/gigabyte/ga-b75m-d3h/early_init.c @@ -82,9 +82,3 @@ read_spd(&spd[2], 0x52, id_only); read_spd(&spd[3], 0x53, id_only); } - -void mainboard_late_rcba_config(void) -{ - /* Enable HECI */ - RCBA32(FD2) &= ~0x2; -}
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36890 )
Change subject: mb/gigabyte/ga-b75m-d3h: Drop useless function-disable setting ......................................................................
Patch Set 1: Code-Review+2
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36890 )
Change subject: mb/gigabyte/ga-b75m-d3h: Drop useless function-disable setting ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36890 )
Change subject: mb/gigabyte/ga-b75m-d3h: Drop useless function-disable setting ......................................................................
mb/gigabyte/ga-b75m-d3h: Drop useless function-disable setting
This bit is already cleared by a reset.
Change-Id: Ib71496011c9621476a7327ba309f367c7fa971e4 Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/36890 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/gigabyte/ga-b75m-d3h/early_init.c 1 file changed, 0 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved Arthur Heymans: Looks good to me, approved
diff --git a/src/mainboard/gigabyte/ga-b75m-d3h/early_init.c b/src/mainboard/gigabyte/ga-b75m-d3h/early_init.c index 65616ff..265e511 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3h/early_init.c +++ b/src/mainboard/gigabyte/ga-b75m-d3h/early_init.c @@ -82,9 +82,3 @@ read_spd(&spd[2], 0x52, id_only); read_spd(&spd[3], 0x53, id_only); } - -void mainboard_late_rcba_config(void) -{ - /* Enable HECI */ - RCBA32(FD2) &= ~0x2; -}