Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Arthur Heymans.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58686 )
Change subject: cpu/amd: Always fetch CPU addr bits at runtime
......................................................................
Patch Set 6:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58686/comment/dee6d31a_7b3b8706
PS4, Line 7: cpu
nit: CPU
Done
https://review.coreboot.org/c/coreboot/+/58686/comment/19314706_d18be08b
PS4, Line 7: Allways
one `l` only: `Always`
Done
https://review.coreboot.org/c/coreboot/+/58686/comment/1d7c3d86_c5774edb
PS4, Line 9: addr bits
Maybe `physical address size`?
Done
https://review.coreboot.org/c/coreboot/+/58686/comment/bf184641_078f59c9
PS4, Line 10: default
nit: value
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58686
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6f9234e091f44a2a03012e7e14c380aefbe717e
Gerrit-Change-Number: 58686
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 03 Nov 2021 08:25:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment