Change in coreboot[master]: mb/clevo/tgl-u: Add Clevo NV41 Tiger Lake laptop support

[Michał Kopeć (Code Review)]

Attention is currently required from: Felix Singer, Michał Żygowski.
Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62498 )

Change subject: mb/clevo/tgl-u: Add Clevo NV41 Tiger Lake laptop support
......................................................................

Patch Set 3:

(7 comments)

File src/mainboard/clevo/tgl-u/Kconfig:

https://review.coreboot.org/c/coreboot/+/62498/comment/2005846a_214e9e1b 
PS1, Line 6: BOARD_CLEVO_TGL_U_COMMON
> Move this to the top please

Done

https://review.coreboot.org/c/coreboot/+/62498/comment/89b7895e_f8c24bfb 
PS1, Line 43: config MAINBOARD_FAMILY
            : 	string
            : 	default "Not Applicable" # Match stock firmware
> Remove

Done

File src/mainboard/clevo/tgl-u/Kconfig.name:

https://review.coreboot.org/c/coreboot/+/62498/comment/f0fad29e_676720f9 
PS1, Line 5: 	select BOARD_CLEVO_NV4X_BASE
> We don't do selects in this file, only in Kconfig. See clevo/cml-u/Kconfig.

hmm, but that's exactly how it's done in clevo/cml-u/Kconfig{,.name}, or am I missing something here?

File src/mainboard/clevo/tgl-u/mainboard.c:

PS1:
> Rename this file to ramstage. […]

Done

File src/mainboard/clevo/tgl-u/variants/nv4x/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/62498/comment/61bc3dd8_8af4844c 
PS1, Line 3: gpio.c
> Use early_gpio. […]

Done

File src/mainboard/clevo/tgl-u/variants/nv4x/gpio.c:

https://review.coreboot.org/c/coreboot/+/62498/comment/c72f54b4_7009efea 
PS1, Line 242: static const struct pad_config early_gpio_table[] = {
             : 	PAD_CFG_NF(GPP_C20, UP_20K, DEEP, NF1), /* UART2_RXD */
             : 	PAD_CFG_NF(GPP_C21, UP_20K, DEEP, NF1), /* UART2_TXD */
             : 	PAD_CFG_TERM_GPO(GPP_U4, 0, NONE, DEEP), /* DGPU_RST#_PCH */
             : 	PAD_CFG_TERM_GPO(GPP_U5, 0, NONE, DEEP), /* DGPU_PWR_EN */
             : };
> Please use gpio_early.c, to align with the other Clevos.

Done

https://review.coreboot.org/c/coreboot/+/62498/comment/1c290b49_051c7881 
PS1, Line 255: const struct pad_config *variant_early_gpio_table(size_t *num)
             : {
             : 	*num = ARRAY_SIZE(early_gpio_table);
             : 	return early_gpio_table;
             : }
> I meant clevo/cml-u/variants/l140cu/gpio_early.c, sorry.

Done