Attention is currently required from: Ravi kumar, Shelley Chen, Martin Roth, Julius Werner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49767 )
Change subject: sc7280: aop loading changes ......................................................................
Patch Set 34:
(26 comments)
File src/soc/qualcomm/sc7280/aop_load_reset.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119020): https://review.coreboot.org/c/coreboot/+/49767/comment/7f9fe435_e257867b PS34, Line 11: bool aop_fw_entry; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119020): https://review.coreboot.org/c/coreboot/+/49767/comment/fecadf7d_a744376c PS34, Line 11: bool aop_fw_entry; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119020): https://review.coreboot.org/c/coreboot/+/49767/comment/c45333c9_919fba85 PS34, Line 13: struct prog aop_fw_prog = code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119020): https://review.coreboot.org/c/coreboot/+/49767/comment/0637b954_fe847fe1 PS34, Line 13: struct prog aop_fw_prog = please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119020): https://review.coreboot.org/c/coreboot/+/49767/comment/c1f9e14e_eab23df6 PS34, Line 14: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119020): https://review.coreboot.org/c/coreboot/+/49767/comment/ecd37866_954fa3cf PS34, Line 14: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119020): https://review.coreboot.org/c/coreboot/+/49767/comment/e8374b1d_20032d72 PS34, Line 16: if (prog_locate(&aop_fw_prog)) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119020): https://review.coreboot.org/c/coreboot/+/49767/comment/23041816_4b996591 PS34, Line 16: if (prog_locate(&aop_fw_prog)) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119020): https://review.coreboot.org/c/coreboot/+/49767/comment/f9a866fc_e94482db PS34, Line 17: die("SOC image: AOP_FW not found"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119020): https://review.coreboot.org/c/coreboot/+/49767/comment/12649362_5fa72a09 PS34, Line 17: die("SOC image: AOP_FW not found"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119020): https://review.coreboot.org/c/coreboot/+/49767/comment/d37f4590_f3d824b6 PS34, Line 19: aop_fw_entry = selfload(&aop_fw_prog); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119020): https://review.coreboot.org/c/coreboot/+/49767/comment/90952abb_a4240c3b PS34, Line 19: aop_fw_entry = selfload(&aop_fw_prog); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119020): https://review.coreboot.org/c/coreboot/+/49767/comment/cf93e6c5_26b645b4 PS34, Line 20: if (!aop_fw_entry) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119020): https://review.coreboot.org/c/coreboot/+/49767/comment/05124acd_466a111e PS34, Line 20: if (!aop_fw_entry) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119020): https://review.coreboot.org/c/coreboot/+/49767/comment/6b0d683c_6905fc6e PS34, Line 21: die("SOC image: AOP load failed"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119020): https://review.coreboot.org/c/coreboot/+/49767/comment/4191dedd_63b8c92e PS34, Line 21: die("SOC image: AOP load failed"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119020): https://review.coreboot.org/c/coreboot/+/49767/comment/66a8b9d6_acb89be9 PS34, Line 23: clock_reset_aop(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119020): https://review.coreboot.org/c/coreboot/+/49767/comment/53e3c700_4d4f5bac PS34, Line 23: clock_reset_aop(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119020): https://review.coreboot.org/c/coreboot/+/49767/comment/79764727_de81e17b PS34, Line 25: printk(BIOS_DEBUG, "\nSOC:AOP brought out of reset.\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119020): https://review.coreboot.org/c/coreboot/+/49767/comment/5c052c3e_7c1b8b48 PS34, Line 25: printk(BIOS_DEBUG, "\nSOC:AOP brought out of reset.\n"); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/mmu.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119020): https://review.coreboot.org/c/coreboot/+/49767/comment/805751c8_f1c8fd7c PS34, Line 25: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119020): https://review.coreboot.org/c/coreboot/+/49767/comment/4e94597e_2b712022 PS34, Line 25: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119020): https://review.coreboot.org/c/coreboot/+/49767/comment/d99008e3_57a1ca10 PS34, Line 26: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119020): https://review.coreboot.org/c/coreboot/+/49767/comment/a3b2386b_856b9473 PS34, Line 26: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/soc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119020): https://review.coreboot.org/c/coreboot/+/49767/comment/047514a3_d6a98267 PS34, Line 15: REGION_SIZE(dram_aop) / KiB); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119020): https://review.coreboot.org/c/coreboot/+/49767/comment/4fde40aa_8caf9d30 PS34, Line 15: REGION_SIZE(dram_aop) / KiB); please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)