Change in coreboot[master]: cpu/intel/slot_1: Select 16KiB bootblock if console is enabled
Keith Hui has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41460 )
Change subject: cpu/intel/slot_1: Select 16KiB bootblock if console is enabled ......................................................................
cpu/intel/slot_1: Select 16KiB bootblock if console is enabled
We previously confirmed [1] that bootblock will grow beyond current 8KiB size if console is enabled. Automatically change to 16KiB if user enabled it in menuconfig.
[1] https://review.coreboot.org/c/coreboot/+/36775
Change-Id: Ic9988c77cf9677167a382aa4dc7dcfa2bc4cbe02 Signed-off-by: Keith Hui buurin@gmail.com --- M src/cpu/intel/slot_1/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/41460/1
diff --git a/src/cpu/intel/slot_1/Kconfig b/src/cpu/intel/slot_1/Kconfig index 1ba71ad..a56208b 100644 --- a/src/cpu/intel/slot_1/Kconfig +++ b/src/cpu/intel/slot_1/Kconfig @@ -34,6 +34,7 @@
config C_ENV_BOOTBLOCK_SIZE hex + default 0x4000 if BOOTBLOCK_CONSOLE default 0x2000
endif
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41460 )
Change subject: cpu/intel/slot_1: Select 16KiB bootblock if console is enabled ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/41460/2/src/cpu/intel/slot_1/Kconfi... File src/cpu/intel/slot_1/Kconfig:
https://review.coreboot.org/c/coreboot/+/41460/2/src/cpu/intel/slot_1/Kconfi... PS2, Line 37: default 0x4000 if BOOTBLOCK_CONSOLE Can't we always default to 0x4000? Or is flash space a scarce resource?
Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41460 )
Change subject: cpu/intel/slot_1: Select 16KiB bootblock if console is enabled ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41460/2/src/cpu/intel/slot_1/Kconfi... File src/cpu/intel/slot_1/Kconfig:
https://review.coreboot.org/c/coreboot/+/41460/2/src/cpu/intel/slot_1/Kconfi... PS2, Line 37: default 0x4000 if BOOTBLOCK_CONSOLE
Can't we always default to 0x4000? Or is flash space a scarce resource?
These boards only have a 256KiB flash and it is not known if they can handle a 512KiB chip. So yes, flash space IS a scarce resource. Heads up: Our LTO effort allows this bootblock to go below 4KiB and I have a patch ready to take advantage of that.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41460 )
Change subject: cpu/intel/slot_1: Select 16KiB bootblock if console is enabled ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/41460/2/src/cpu/intel/slot_1/Kconfi... File src/cpu/intel/slot_1/Kconfig:
https://review.coreboot.org/c/coreboot/+/41460/2/src/cpu/intel/slot_1/Kconfi... PS2, Line 37: default 0x4000 if BOOTBLOCK_CONSOLE
These boards only have a 256KiB flash and it is not known if they can handle a 512KiB chip. […]
Ack
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41460 )
Change subject: cpu/intel/slot_1: Select 16KiB bootblock if console is enabled ......................................................................
cpu/intel/slot_1: Select 16KiB bootblock if console is enabled
We previously confirmed [1] that bootblock will grow beyond current 8KiB size if console is enabled. Automatically change to 16KiB if user enabled it in menuconfig.
[1] https://review.coreboot.org/c/coreboot/+/36775
Change-Id: Ic9988c77cf9677167a382aa4dc7dcfa2bc4cbe02 Signed-off-by: Keith Hui buurin@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41460 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/cpu/intel/slot_1/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/cpu/intel/slot_1/Kconfig b/src/cpu/intel/slot_1/Kconfig index 6928335..2b6deb6 100644 --- a/src/cpu/intel/slot_1/Kconfig +++ b/src/cpu/intel/slot_1/Kconfig @@ -32,6 +32,7 @@
config C_ENV_BOOTBLOCK_SIZE hex + default 0x4000 if BOOTBLOCK_CONSOLE default 0x2000
endif
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41460 )
Change subject: cpu/intel/slot_1: Select 16KiB bootblock if console is enabled ......................................................................
Patch Set 3:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4871 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4870 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4869 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4868
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Felix Held (Code Review)
-
Keith Hui (Code Review)