Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/86028?usp=email )
Change subject: soc/mediatek: Introduce mtk_edp_enable() to fix eDP init flow
......................................................................
Patch Set 3:
(1 comment)
File src/soc/mediatek/common/display.c:
https://review.coreboot.org/c/coreboot/+/86028/comment/15f102ec_1b09bdfe?usp... :
PS3, Line 40: __weak int mtk_edp_init(struct mtk_dp *mtk_dp, struct edid *edid);
`Using weak declarations can have unintended link defects`
Please fix.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86028?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ief847320caca1af1c6deb242dc224e7698a6603c
Gerrit-Change-Number: 86028
Gerrit-PatchSet: 3
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Fri, 17 Jan 2025 02:41:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No