Attention is currently required from: Máté Kukri (mkukri), Michael Niewöhner, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55250 )
Change subject: [WIP] src/superio/smsc: Add support for the SCH5555
......................................................................
Patch Set 4:
(1 comment)
File src/superio/smsc/sch5555/ramstage.c:
https://review.coreboot.org/c/coreboot/+/55250/comment/499255b6_c47e2931
PS4, Line 54: uint8_t tmp = pnp_read_config(lpci, bar + 1);
: pnp_write_config(lpci, bar + 1, tmp | 0x80);
That's only defined in simple device "mode".
CB:55255 to the rescue! 😊
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55250
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9323198f1139cd0c3dd37f977ae7693b721654f4
Gerrit-Change-Number: 55250
Gerrit-PatchSet: 4
Gerrit-Owner: Máté Kukri (mkukri)
kukri.mate@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Máté Kukri (mkukri)
kukri.mate@gmail.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sun, 06 Jun 2021 17:25:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Máté Kukri (mkukri)
kukri.mate@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment