Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 )
Change subject: lenovo/x230: introduce FHD variant ......................................................................
Patch Set 6:
Patch Set 6:
Patch Set 6:
Patch Set 6:
Patch Set 6:
Patch Set 6:
Patch Set 6: -Code-Review
> On the device with FHD-mod booting works as well, but graphical output of coreboot, seabios and grub is only visible if an additional external monitor is attached via VGA or DP. The internal FHD panel becomes active as soon as the linux kernel takes over. Right now I am unsure if this is due to misconfiguration on my part or if coreboot/libgfxinit needs to be told to use eDP1 for output on modded devices. Hints for further tests appreciated.
Can you test revision 5 of the patch? I haven't looked into libgfxinit, so it might be that GFX_GMA_INTERNAL_IS_LVDS is used to determine which backlight interface to use
I have tried reversion 5 without success After reading Documentation/gfx/libgfxinit.md I also tried explicitly declaring FX_GMA_INTERNAL_IS_EDP (which should not be necessary since it is the default) I also tried moving DP3 to the top of the list of ports to probe in src/mainboard/lenovo/x230/variants/x230_fhd/gma-mainboard.ads but that did not change anything either
any other ideas?
How did you download revision 5?
git reset origin/master --hard git pull git fetch https://review.coreboot.org/coreboot refs/changes/50/28950/5 && git cherry-pick FETCH_HEAD
Right, so this cherry-picks the change on top of current master, which isn't the same than "master patchset 5 was created on". Could you please repeat the test running this command before fetching and cherry-picking?
git checkout 034e5e6f
same result. LVDS is disabled and full functionality of FHD-panel in linux (as intended), but no coreboot console output on the FHD-panel during boot until kernel takes over.
Could it be that the backlight is not lighting up? I am a bit out of ideas.
-
Angel Pons (Code Review)