[S] Change in coreboot[main]: mb/lenovo/m900_tiny: enable power LED blink in S3 and S4 - coreboot-gerrit

26 Apr 2025


      Attention is currently required from: Alexander Couzens, Maciej Pijanowski, Martin L Roth, Michał Kopeć, Michał Żygowski.
Paul Menzel has posted comments on this change by Michał Kopeć. ( https://review.coreboot.org/c/coreboot/+/84860?usp=email )
Change subject: mb/lenovo/m900_tiny: enable power LED blink in S3 and S4
......................................................................
Patch Set 10:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84860/comment/066bd6c6_6bb2fafc?usp... :
PS10, Line 14: 
Could you elaborate, why this is done via SMI, and not ACPI or even by an OS driver?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/84860?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I121e0ef3e47aec1cacdace3f2af47a3fdacf69cf
Gerrit-Change-Number: 84860
Gerrit-PatchSet: 10
Gerrit-Owner: Michał Kopeć michal.kopec@3mdeb.com
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Maciej Pijanowski maciej.pijanowski@3mdeb.com
Gerrit-Reviewer: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Maciej Pijanowski maciej.pijanowski@3mdeb.com
Gerrit-Attention: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Attention: Michał Kopeć michal.kopec@3mdeb.com
Gerrit-Attention: Alexander Couzens lynxis@fe80.eu
Gerrit-Comment-Date: Sat, 26 Apr 2025 06:19:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No