Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/28803 )
Change subject: mb/google/poppy/variant/nocturne: increase touchscreen reset delay
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/28803/1/src/mainboard/google/poppy/variants/...
File src/mainboard/google/poppy/variants/nocturne/devicetree.cb:
https://review.coreboot.org/#/c/28803/1/src/mainboard/google/poppy/variants/...
PS1, Line 294: register "generic.reset_delay_ms" = "10"
I think it would be good to add the "disable_gpio_export_in_crs" option as well.
--
To view, visit
https://review.coreboot.org/28803
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I102b57ea5a10d22bee6d4f7c6f114b380a5d586b
Gerrit-Change-Number: 28803
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 29 Sep 2018 22:19:32 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No