Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37945 )
Change subject: superio/nuvoton: add common HWM bank select function ......................................................................
superio/nuvoton: add common HWM bank select function
Change-Id: I828b6caa37e52c13e1876c7ca4edbd171e70d3f7 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/superio/nuvoton/Makefile.inc M src/superio/nuvoton/common/Kconfig A src/superio/nuvoton/common/hwm.c A src/superio/nuvoton/common/hwm.h 4 files changed, 61 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/37945/1
diff --git a/src/superio/nuvoton/Makefile.inc b/src/superio/nuvoton/Makefile.inc index eae0f63..d92b453 100644 --- a/src/superio/nuvoton/Makefile.inc +++ b/src/superio/nuvoton/Makefile.inc @@ -17,6 +17,9 @@ bootblock-$(CONFIG_SUPERIO_NUVOTON_COMMON_PRE_RAM) += common/early_serial.c romstage-$(CONFIG_SUPERIO_NUVOTON_COMMON_PRE_RAM) += common/early_serial.c
+## include generic Nuvoton HWM driver +ramstage-$(CONFIG_SUPERIO_NUVOTON_COMMON_HWM) += common/hwm.c + subdirs-$(CONFIG_SUPERIO_NUVOTON_WPCM450) += wpcm450 subdirs-$(CONFIG_SUPERIO_NUVOTON_NCT5104D) += nct5104d subdirs-$(CONFIG_SUPERIO_NUVOTON_NCT5539D) += nct5539d diff --git a/src/superio/nuvoton/common/Kconfig b/src/superio/nuvoton/common/Kconfig index 0af671f..0af556c 100644 --- a/src/superio/nuvoton/common/Kconfig +++ b/src/superio/nuvoton/common/Kconfig @@ -17,3 +17,7 @@ # pre-ram. config SUPERIO_NUVOTON_COMMON_PRE_RAM bool + +# Generic Nuvoton HWM driver +config SUPERIO_NUVOTON_COMMON_HWM + bool diff --git a/src/superio/nuvoton/common/hwm.c b/src/superio/nuvoton/common/hwm.c new file mode 100644 index 0000000..b150617 --- /dev/null +++ b/src/superio/nuvoton/common/hwm.c @@ -0,0 +1,28 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2019 Felix Held felix-coreboot@felixheld.de + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +//Nuvoton is a Winbond spin-off, so this code is for both + +#include <stdint.h> +#include <superio/hwm5_conf.h> +#include "hwm.h" + +#define HWM_BANK_SELECT 0x4e + +void nuvoton_hwm_select_bank(const u16 base, const u8 bank) +{ + pnp_write_hwm5_index(base, HWM_BANK_SELECT, bank); +} diff --git a/src/superio/nuvoton/common/hwm.h b/src/superio/nuvoton/common/hwm.h new file mode 100644 index 0000000..c887ec2 --- /dev/null +++ b/src/superio/nuvoton/common/hwm.h @@ -0,0 +1,26 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2019 Felix Held felix-coreboot@felixheld.de + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef SUPERIO_NUVOTON_COMMON_HWM_H +#define SUPERIO_NUVOTON_COMMON_HWM_H + +//Nuvoton is a Winbond spin-off, so this code is for both + +#include <stdint.h> + +void nuvoton_hwm_select_bank(const u16 base, const u8 bank); + +#endif /* SUPERIO_NUVOTON_COMMON_HWM_H */
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37945 )
Change subject: superio/nuvoton: add common HWM bank select function ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37945 )
Change subject: superio/nuvoton: add common HWM bank select function ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/37945/1/src/superio/nuvoton/common/... File src/superio/nuvoton/common/hwm.h:
https://review.coreboot.org/c/coreboot/+/37945/1/src/superio/nuvoton/common/... PS1, Line 20: //Nuvoton is a Winbond spin-off, so this code is for both I'd use C-style comments here, or at least a space after the double slash
https://review.coreboot.org/c/coreboot/+/37945/1/src/superio/nuvoton/common/... File src/superio/nuvoton/common/hwm.c:
https://review.coreboot.org/c/coreboot/+/37945/1/src/superio/nuvoton/common/... PS1, Line 17: //Nuvoton is a Winbond spin-off, so this code is for both Same
Hello HAOUAS Elyes, Angel Pons, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37945
to look at the new patch set (#2).
Change subject: superio/nuvoton: add common HWM bank select function ......................................................................
superio/nuvoton: add common HWM bank select function
Change-Id: I828b6caa37e52c13e1876c7ca4edbd171e70d3f7 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/superio/nuvoton/Makefile.inc M src/superio/nuvoton/common/Kconfig A src/superio/nuvoton/common/hwm.c A src/superio/nuvoton/common/hwm.h 4 files changed, 61 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/37945/2
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37945 )
Change subject: superio/nuvoton: add common HWM bank select function ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37945/1/src/superio/nuvoton/common/... File src/superio/nuvoton/common/hwm.h:
https://review.coreboot.org/c/coreboot/+/37945/1/src/superio/nuvoton/common/... PS1, Line 20: //Nuvoton is a Winbond spin-off, so this code is for both
I'd use C-style comments here, or at least a space after the double slash
Done
https://review.coreboot.org/c/coreboot/+/37945/1/src/superio/nuvoton/common/... File src/superio/nuvoton/common/hwm.c:
https://review.coreboot.org/c/coreboot/+/37945/1/src/superio/nuvoton/common/... PS1, Line 17: //Nuvoton is a Winbond spin-off, so this code is for both
Same
Done
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37945 )
Change subject: superio/nuvoton: add common HWM bank select function ......................................................................
Patch Set 2: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37945 )
Change subject: superio/nuvoton: add common HWM bank select function ......................................................................
superio/nuvoton: add common HWM bank select function
Change-Id: I828b6caa37e52c13e1876c7ca4edbd171e70d3f7 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/37945 Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/superio/nuvoton/Makefile.inc M src/superio/nuvoton/common/Kconfig A src/superio/nuvoton/common/hwm.c A src/superio/nuvoton/common/hwm.h 4 files changed, 61 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
diff --git a/src/superio/nuvoton/Makefile.inc b/src/superio/nuvoton/Makefile.inc index eae0f63..d92b453 100644 --- a/src/superio/nuvoton/Makefile.inc +++ b/src/superio/nuvoton/Makefile.inc @@ -17,6 +17,9 @@ bootblock-$(CONFIG_SUPERIO_NUVOTON_COMMON_PRE_RAM) += common/early_serial.c romstage-$(CONFIG_SUPERIO_NUVOTON_COMMON_PRE_RAM) += common/early_serial.c
+## include generic Nuvoton HWM driver +ramstage-$(CONFIG_SUPERIO_NUVOTON_COMMON_HWM) += common/hwm.c + subdirs-$(CONFIG_SUPERIO_NUVOTON_WPCM450) += wpcm450 subdirs-$(CONFIG_SUPERIO_NUVOTON_NCT5104D) += nct5104d subdirs-$(CONFIG_SUPERIO_NUVOTON_NCT5539D) += nct5539d diff --git a/src/superio/nuvoton/common/Kconfig b/src/superio/nuvoton/common/Kconfig index 0af671f..0af556c 100644 --- a/src/superio/nuvoton/common/Kconfig +++ b/src/superio/nuvoton/common/Kconfig @@ -17,3 +17,7 @@ # pre-ram. config SUPERIO_NUVOTON_COMMON_PRE_RAM bool + +# Generic Nuvoton HWM driver +config SUPERIO_NUVOTON_COMMON_HWM + bool diff --git a/src/superio/nuvoton/common/hwm.c b/src/superio/nuvoton/common/hwm.c new file mode 100644 index 0000000..bfc916f --- /dev/null +++ b/src/superio/nuvoton/common/hwm.c @@ -0,0 +1,28 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2019 Felix Held felix-coreboot@felixheld.de + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +/* Nuvoton is a Winbond spin-off, so this code is for both */ + +#include <stdint.h> +#include <superio/hwm5_conf.h> +#include "hwm.h" + +#define HWM_BANK_SELECT 0x4e + +void nuvoton_hwm_select_bank(const u16 base, const u8 bank) +{ + pnp_write_hwm5_index(base, HWM_BANK_SELECT, bank); +} diff --git a/src/superio/nuvoton/common/hwm.h b/src/superio/nuvoton/common/hwm.h new file mode 100644 index 0000000..15dcf62 --- /dev/null +++ b/src/superio/nuvoton/common/hwm.h @@ -0,0 +1,26 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2019 Felix Held felix-coreboot@felixheld.de + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef SUPERIO_NUVOTON_COMMON_HWM_H +#define SUPERIO_NUVOTON_COMMON_HWM_H + +/* Nuvoton is a Winbond spin-off, so this code is for both */ + +#include <stdint.h> + +void nuvoton_hwm_select_bank(const u16 base, const u8 bank); + +#endif /* SUPERIO_NUVOTON_COMMON_HWM_H */
-
Angel Pons (Code Review) -
Felix Held (Code Review)
-
HAOUAS Elyes (Code Review)