Keith Hui has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41225 )
Change subject: mb/asus/p8z77-m_pro: Remove PS/2 keyboard & mouse duplicate ......................................................................
mb/asus/p8z77-m_pro: Remove PS/2 keyboard & mouse duplicate
PS/2 keyboard and mouse devices are declared twice in the DSDT, once in mainboard and once in southbridge. It would appear in Windows Device Manager as two PS/2 keyboards and two PS/2 mouses, all with resource conflicts. This change drops the declaration from mainboard.
The issue was discovered when this setup was copied for p8z77-m and then boot tested there.
Change-Id: I746a960aaf3992acbcb6a7364641fc4fd12002d2 Signed-off-by: Keith Hui buurin@gmail.com --- M src/mainboard/asus/p8z77-m_pro/dsdt.asl 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/41225/1
diff --git a/src/mainboard/asus/p8z77-m_pro/dsdt.asl b/src/mainboard/asus/p8z77-m_pro/dsdt.asl index 21b3954..e5446a9 100644 --- a/src/mainboard/asus/p8z77-m_pro/dsdt.asl +++ b/src/mainboard/asus/p8z77-m_pro/dsdt.asl @@ -12,7 +12,6 @@ ) { #include "acpi/platform.asl" - #include "acpi/superio.asl" #include <cpu/intel/common/acpi/cpu.asl> #include <southbridge/intel/common/acpi/platform.asl>
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41225 )
Change subject: mb/asus/p8z77-m_pro: Remove PS/2 keyboard & mouse duplicate ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41225 )
Change subject: mb/asus/p8z77-m_pro: Remove PS/2 keyboard & mouse duplicate ......................................................................
Patch Set 1: Code-Review+1
Hello build bot (Jenkins), Paul Menzel, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41225
to look at the new patch set (#2).
Change subject: mb/asus/p8z77-m_pro: Remove PS/2 keyboard & mouse duplicate ......................................................................
mb/asus/p8z77-m_pro: Remove PS/2 keyboard & mouse duplicate
PS/2 keyboard and mouse devices are declared twice in the DSDT, once in mainboard and once in southbridge. It would appear in Windows Device Manager as two PS/2 keyboards and two PS/2 mouses, all with resource conflicts. This change drops the declaration from mainboard.
The issue was discovered when this setup was copied for p8z77-m and being boot tested.
Change-Id: I746a960aaf3992acbcb6a7364641fc4fd12002d2 Signed-off-by: Keith Hui buurin@gmail.com --- M src/mainboard/asus/p8z77-m_pro/dsdt.asl 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/41225/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41225 )
Change subject: mb/asus/p8z77-m_pro: Remove PS/2 keyboard & mouse duplicate ......................................................................
Patch Set 3: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41225 )
Change subject: mb/asus/p8z77-m_pro: Remove PS/2 keyboard & mouse duplicate ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41225 )
Change subject: mb/asus/p8z77-m_pro: Remove PS/2 keyboard & mouse duplicate ......................................................................
mb/asus/p8z77-m_pro: Remove PS/2 keyboard & mouse duplicate
PS/2 keyboard and mouse devices are declared twice in the DSDT, once in mainboard and once in southbridge. It would appear in Windows Device Manager as two PS/2 keyboards and two PS/2 mouses, all with resource conflicts. This change drops the declaration from mainboard.
The issue was discovered when this setup was copied for p8z77-m and being boot tested.
Change-Id: I746a960aaf3992acbcb6a7364641fc4fd12002d2 Signed-off-by: Keith Hui buurin@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41225 Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/asus/p8z77-m_pro/dsdt.asl 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/asus/p8z77-m_pro/dsdt.asl b/src/mainboard/asus/p8z77-m_pro/dsdt.asl index 5f90122..a5ab91d 100644 --- a/src/mainboard/asus/p8z77-m_pro/dsdt.asl +++ b/src/mainboard/asus/p8z77-m_pro/dsdt.asl @@ -11,7 +11,6 @@ ) { #include "acpi/platform.asl" - #include "acpi/superio.asl" #include <cpu/intel/common/acpi/cpu.asl> #include <southbridge/intel/common/acpi/platform.asl>
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Keith Hui (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)