Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36884 )
Change subject: nb/intel/sandybridge: Configure DCACHE_BSP_STACK_SIZE ......................................................................
nb/intel/sandybridge: Configure DCACHE_BSP_STACK_SIZE
The romstage default is to set stack guards at 0x2000 below end of stack. The code is now overwrites some of the stack guards so increase the stack size to a comfortable 0x2800.
Change-Id: I91f559383a987241b343e743d11291f2c100f7f5 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/northbridge/intel/sandybridge/Kconfig 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/36884/1
diff --git a/src/northbridge/intel/sandybridge/Kconfig b/src/northbridge/intel/sandybridge/Kconfig index 64ce4d8..288dd09 100644 --- a/src/northbridge/intel/sandybridge/Kconfig +++ b/src/northbridge/intel/sandybridge/Kconfig @@ -76,6 +76,9 @@ hex default 0xfefe0000
+config DCACHE_BSP_STACK_SIZE + hex + default 0x2800
if USE_NATIVE_RAMINIT
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36884 )
Change subject: nb/intel/sandybridge: Configure DCACHE_BSP_STACK_SIZE ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36884 )
Change subject: nb/intel/sandybridge: Configure DCACHE_BSP_STACK_SIZE ......................................................................
nb/intel/sandybridge: Configure DCACHE_BSP_STACK_SIZE
The romstage default is to set stack guards at 0x2000 below end of stack. The code is now overwrites some of the stack guards so increase the stack size to a comfortable 0x2800.
Change-Id: I91f559383a987241b343e743d11291f2c100f7f5 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/36884 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/northbridge/intel/sandybridge/Kconfig 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/northbridge/intel/sandybridge/Kconfig b/src/northbridge/intel/sandybridge/Kconfig index 64ce4d8..288dd09 100644 --- a/src/northbridge/intel/sandybridge/Kconfig +++ b/src/northbridge/intel/sandybridge/Kconfig @@ -76,6 +76,9 @@ hex default 0xfefe0000
+config DCACHE_BSP_STACK_SIZE + hex + default 0x2800
if USE_NATIVE_RAMINIT
-
Arthur Heymans (Code Review) -
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)