Attention is currently required from: Maulik V Vaghela, Mario Scheithauer, Subrata Banik, Werner Zeh, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54959 )
Change subject: soc/intel/elkhartlake: Update FSP-S UPD LPSS related configs
......................................................................
Patch Set 7:
(2 comments)
File src/soc/intel/elkhartlake/fsp_params.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120151):
https://review.coreboot.org/c/coreboot/+/54959/comment/40f11312_1d47162c
PS7, Line 104: params->SerialIoUartRxPinMuxPolicy[0] = 0x2B01020C; //GPIO pin mux for GPP_T12
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120151):
https://review.coreboot.org/c/coreboot/+/54959/comment/52105e8e_88a8816e
PS7, Line 105: params->SerialIoUartTxPinMuxPolicy[0] = 0x2B01120D; //GPIO pin mux for GPP_T13
line over 96 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54959
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib0c3cd1d37ff9892d09d6d86ac50e230549c7e53
Gerrit-Change-Number: 54959
Gerrit-PatchSet: 7
Gerrit-Owner: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 27 May 2021 07:40:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment