[M] Change in coreboot[main]: soc/amd/glinda/cpu: Implement soc_fill_cpu_cache_info helper

[Angel Pons (Code Review)]

Attention is currently required from: Felix Held, Jérémy Compostella, Maximilian Brune, Naresh Solanki, Patrick Rudolph, Paul Menzel.

Angel Pons has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/85640?usp=email )

Change subject: soc/amd/glinda/cpu: Implement soc_fill_cpu_cache_info helper
......................................................................

Patch Set 4:

(1 comment)

File src/soc/amd/glinda/cpu.c:

https://review.coreboot.org/c/coreboot/+/85640/comment/309f493e_bcc11bc1?usp... :
PS4, Line 41: __fls(info->num_cores_shared-1);
> Yes __fls it uses log2.

What Max suggests is using `log2()` since that's what the spec says. Especially considering that `__fls()` literally just calls `log2()`: https://github.com/coreboot/coreboot/blob/8bb59ca2faee83ba50850900c8b4edf933...

```
static inline int __fls(u32 x) { return log2(x); }
```

I agree with this change and I would also add spaces around the `-`:

```suggestion
    info->unique_id = cpuid_cpu_id >> log2(info->num_cores_shared - 1);
```

Though now I wonder, is `info->num_cores_shared` ever 0? (Subtracting would underflow) And is it ever 1? (`log2(0)` is -1, IIRC negative shifts are undefined behaviour)