Attention is currently required from: Raul Rangel, Furquan Shaikh, Tim Wawrzynczak. Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55027 )
Change subject: acpi/device: Add ability to generate proper _STA for PowerResource ......................................................................
Patch Set 2:
(1 comment)
File src/include/acpi/acpi_device.h:
https://review.coreboot.org/c/coreboot/+/55027/comment/773395a2_fbb2c3da PS2, Line 459: : /* Write a _STA method that checks the state of the GPIOs. Otherwise : * the _STA method will always return _ON. : */ : bool enable_status; It looks the comment and name of bool need to explain a litter bit better for next person whom will define acpi power resource. Otherwise my first impression will be enable_status=0 will be _STA to off and enable_status=1 will be _STA to on. What about change to "force_on" or "always enabled" or something similar?