Attention is currently required from: Daniel Kang, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun, YH Lin.
Jamie Ryu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81560?usp=email )
Change subject: mb/google/screebo: Add FW_CONFIG and device for VPU
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/rex/variants/screebo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/81560/comment/a57ed9cc_98f02b35 :
PS1, Line 33: field VPU 22
: option VPU_DIS 0
: option VPU_EN 1
: end
Just curious why is 22 being chosen?
Subrata, YH made config star changes and it is merged now. https://chrome-internal-review.googlesource.com/c/chromeos/project/rex/scree...
YH, I'd like to keep the same CBI bit definition with rex0 variant for VPU enablement. https://github.com/coreboot/coreboot/blob/main/src/mainboard/google/rex/vari...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81560?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6d7b35dbf8ac9b0abb42f64a947b4bb94f3c6b0f
Gerrit-Change-Number: 81560
Gerrit-PatchSet: 2
Gerrit-Owner: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Daniel Kang
daniel.h.kang@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: YH Lin
yueherngl@google.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Daniel Kang
daniel.h.kang@intel.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Wed, 03 Apr 2024 09:48:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: YH Lin
yueherngl@google.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment