Peter Lemenkov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37302 )
Change subject: mb/lenovo/s230u/devicetree: Use subsystemid inheritance ......................................................................
mb/lenovo/s230u/devicetree: Use subsystemid inheritance
Change-Id: I70eabc0b03709409d997ccbe8b8e257d68aec338 Signed-off-by: Peter Lemenkov lemenkov@gmail.com --- M src/mainboard/lenovo/s230u/devicetree.cb 1 file changed, 35 insertions(+), 76 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/37302/1
diff --git a/src/mainboard/lenovo/s230u/devicetree.cb b/src/mainboard/lenovo/s230u/devicetree.cb index 15d323d..8d1ec4a 100644 --- a/src/mainboard/lenovo/s230u/devicetree.cb +++ b/src/mainboard/lenovo/s230u/devicetree.cb @@ -27,14 +27,12 @@ end end device domain 0x0 on - device pci 00.0 on # Host bridge Host bridge - subsystemid 0x17aa 0x2205 - end - device pci 01.0 off # PCIe Bridge for discrete graphics - end - device pci 02.0 on # Internal graphics VGA controller - subsystemid 0x17aa 0x2205 - end + subsystemid 0x17aa 0x2205 inherit + + device pci 00.0 on end Host bridge Host bridge + device pci 01.0 off end PCIe Bridge for discrete graphics + device pci 02.0 on end Internal graphics VGA controller + chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH register "c2_latency" = "0x0065" register "docking_supported" = "1" @@ -55,83 +53,44 @@ register "spi_uvscc" = "0x2005" register "spi_lvscc" = "0x2005"
- device pci 14.0 on # USB 3.0 Controller - subsystemid 0x17aa 0x2205 - end - device pci 16.0 off # Management Engine Interface 1 - end - device pci 16.1 off # Management Engine Interface 2 - end - device pci 16.2 off # Management Engine IDE-R - end - device pci 16.3 off # Management Engine KT - end - device pci 19.0 off # Intel Gigabit Ethernet - end - device pci 1a.0 on # USB2 EHCI #2 - subsystemid 0x17aa 0x2205 - end - device pci 1b.0 on # High Definition Audio Audio controller - subsystemid 0x17aa 0x2205 - end - device pci 1c.0 on # PCIe Port #1 - subsystemid 0x17aa 0x2205 - end - device pci 1c.1 on # PCIe Port #2 - subsystemid 0x17aa 0x2205 - end - device pci 1c.2 off # PCIe Port #3 - end - device pci 1c.3 on # PCIe Port #4 - subsystemid 0x17aa 0x2205 - end - device pci 1c.4 off # PCIe Port #5 - end - device pci 1c.5 off # PCIe Port #6 - end - device pci 1c.6 off # PCIe Port #7 - end - device pci 1c.7 off # PCIe Port #8 - end - device pci 1d.0 on # USB2 EHCI #1 - subsystemid 0x17aa 0x2205 - end - device pci 1e.0 off # PCI bridge - end + device pci 14.0 on end USB 3.0 Controller + device pci 16.0 off end Management Engine Interface 1 + device pci 16.1 off end Management Engine Interface 2 + device pci 16.2 off end Management Engine IDE-R + device pci 16.3 off end Management Engine KT + device pci 19.0 off end Intel Gigabit Ethernet + device pci 1a.0 on end USB2 EHCI #2 + device pci 1b.0 on end High Definition Audio Audio controller + device pci 1c.0 on end PCIe Port #1 + device pci 1c.1 on end PCIe Port #2 + device pci 1c.2 off end PCIe Port #3 + device pci 1c.3 on end PCIe Port #4 + device pci 1c.4 off end PCIe Port #5 + device pci 1c.5 off end PCIe Port #6 + device pci 1c.6 off end PCIe Port #7 + device pci 1c.7 off end PCIe Port #8 + device pci 1d.0 on end USB2 EHCI #1 + device pci 1e.0 off end PCI bridge device pci 1f.0 on # LPC bridge PCI-LPC bridge - subsystemid 0x17aa 0x2205 chip drivers/pc80/tpm device pnp 0c31.0 on end end end - device pci 1f.2 on # SATA Controller 1 - subsystemid 0x17aa 0x2205 - end + device pci 1f.2 on end SATA Controller 1 device pci 1f.3 on # SMBus - subsystemid 0x17aa 0x2205 chip drivers/i2c/at24rf08c # eeprom, 8 virtual devices, same chip - device i2c 54 on - end - device i2c 55 on - end - device i2c 56 on - end - device i2c 57 on - end - device i2c 5c on - end - device i2c 5d on - end - device i2c 5e on - end - device i2c 5f on - end + device i2c 54 on end + device i2c 55 on end + device i2c 56 on end + device i2c 57 on end + device i2c 5c on end + device i2c 5d on end + device i2c 5e on end + device i2c 5f on end end end - device pci 1f.5 off # SATA Controller 2 - end - device pci 1f.6 off # Thermal - end + device pci 1f.5 off end SATA Controller 2 + device pci 1f.6 off end Thermal end end end
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37302 )
Change subject: mb/lenovo/s230u/devicetree: Use subsystemid inheritance ......................................................................
Patch Set 1: Code-Review+1
(8 comments)
https://review.coreboot.org/c/coreboot/+/37302/1/src/mainboard/lenovo/s230u/... File src/mainboard/lenovo/s230u/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/37302/1/src/mainboard/lenovo/s230u/... PS1, Line 32: # ?
https://review.coreboot.org/c/coreboot/+/37302/1/src/mainboard/lenovo/s230u/... PS1, Line 33: P device pci 01.0 off end # PCIe Bridge for discrete graphics ...
https://review.coreboot.org/c/coreboot/+/37302/1/src/mainboard/lenovo/s230u/... PS1, Line 34: d I #
https://review.coreboot.org/c/coreboot/+/37302/1/src/mainboard/lenovo/s230u/... PS1, Line 56: on end USB 3.0 Controller : device pci 16.0 off end Management Engine Interface 1 : device pci 16.1 off end Management Engine Interface 2 : device pci 16.2 off end Management Engine IDE-R : device pci 16.3 off end Management Engine KT : device pci 19.0 off end Intel Gigabit Ethernet : device pci 1a.0 on end USB2 EHCI #2 : device pci 1b.0 on end High Definition Audio Audio controller : device pci 1c.0 on end PCIe Port #1 : device pci 1c.1 on end PCIe Port #2 : device pci 1c.2 off end PCIe Port #3 : device pci 1c.3 on end PCIe Port #4 : device pci 1c.4 off end PCIe Port #5 : device pci 1c.5 off end PCIe Port #6 : device pci 1c.6 off end PCIe Port #7 : device pci 1c.7 off end PCIe Port #8 : device pci 1d.0 on end USB2 EHCI #1 : device pci 1e.0 off end PC missing '#'
https://review.coreboot.org/c/coreboot/+/37302/1/src/mainboard/lenovo/s230u/... PS1, Line 79: # ?
https://review.coreboot.org/c/coreboot/+/37302/1/src/mainboard/lenovo/s230u/... PS1, Line 82: n end : device i2c 55 on end : device i2c 56 on end : device i2c 57 on end : device i2c 5c on end : device i2c 5d on end : device i2c 5e on end : device i2c 5f on e #
https://review.coreboot.org/c/coreboot/+/37302/1/src/mainboard/lenovo/s230u/... PS1, Line 92: # ?
https://review.coreboot.org/c/coreboot/+/37302/1/src/mainboard/lenovo/s230u/... PS1, Line 93: # ?
Hello Alexander Couzens, Patrick Rudolph, HAOUAS Elyes, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37302
to look at the new patch set (#4).
Change subject: mb/lenovo/s230u/devicetree: Use subsystemid inheritance ......................................................................
mb/lenovo/s230u/devicetree: Use subsystemid inheritance
Change-Id: I70eabc0b03709409d997ccbe8b8e257d68aec338 Signed-off-by: Peter Lemenkov lemenkov@gmail.com --- M src/mainboard/lenovo/s230u/devicetree.cb 1 file changed, 35 insertions(+), 76 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/37302/4
Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37302 )
Change subject: mb/lenovo/s230u/devicetree: Use subsystemid inheritance ......................................................................
Patch Set 4:
(8 comments)
https://review.coreboot.org/c/coreboot/+/37302/1/src/mainboard/lenovo/s230u/... File src/mainboard/lenovo/s230u/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/37302/1/src/mainboard/lenovo/s230u/... PS1, Line 32:
# ?
Done
https://review.coreboot.org/c/coreboot/+/37302/1/src/mainboard/lenovo/s230u/... PS1, Line 33: P
device pci 01.0 off end # PCIe Bridge for discrete graphics ...
Done
https://review.coreboot.org/c/coreboot/+/37302/1/src/mainboard/lenovo/s230u/... PS1, Line 34: d I
#
Done
https://review.coreboot.org/c/coreboot/+/37302/1/src/mainboard/lenovo/s230u/... PS1, Line 56: on end USB 3.0 Controller : device pci 16.0 off end Management Engine Interface 1 : device pci 16.1 off end Management Engine Interface 2 : device pci 16.2 off end Management Engine IDE-R : device pci 16.3 off end Management Engine KT : device pci 19.0 off end Intel Gigabit Ethernet : device pci 1a.0 on end USB2 EHCI #2 : device pci 1b.0 on end High Definition Audio Audio controller : device pci 1c.0 on end PCIe Port #1 : device pci 1c.1 on end PCIe Port #2 : device pci 1c.2 off end PCIe Port #3 : device pci 1c.3 on end PCIe Port #4 : device pci 1c.4 off end PCIe Port #5 : device pci 1c.5 off end PCIe Port #6 : device pci 1c.6 off end PCIe Port #7 : device pci 1c.7 off end PCIe Port #8 : device pci 1d.0 on end USB2 EHCI #1 : device pci 1e.0 off end PC
missing '#'
Done
https://review.coreboot.org/c/coreboot/+/37302/1/src/mainboard/lenovo/s230u/... PS1, Line 79:
# ?
Done
https://review.coreboot.org/c/coreboot/+/37302/1/src/mainboard/lenovo/s230u/... PS1, Line 82: n end : device i2c 55 on end : device i2c 56 on end : device i2c 57 on end : device i2c 5c on end : device i2c 5d on end : device i2c 5e on end : device i2c 5f on e
#
Done
https://review.coreboot.org/c/coreboot/+/37302/1/src/mainboard/lenovo/s230u/... PS1, Line 92:
# ?
Done
https://review.coreboot.org/c/coreboot/+/37302/1/src/mainboard/lenovo/s230u/... PS1, Line 93:
# ?
Done
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37302 )
Change subject: mb/lenovo/s230u/devicetree: Use subsystemid inheritance ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37302 )
Change subject: mb/lenovo/s230u/devicetree: Use subsystemid inheritance ......................................................................
mb/lenovo/s230u/devicetree: Use subsystemid inheritance
Change-Id: I70eabc0b03709409d997ccbe8b8e257d68aec338 Signed-off-by: Peter Lemenkov lemenkov@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37302 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M src/mainboard/lenovo/s230u/devicetree.cb 1 file changed, 35 insertions(+), 76 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
diff --git a/src/mainboard/lenovo/s230u/devicetree.cb b/src/mainboard/lenovo/s230u/devicetree.cb index 15d323d..b03e2f9 100644 --- a/src/mainboard/lenovo/s230u/devicetree.cb +++ b/src/mainboard/lenovo/s230u/devicetree.cb @@ -27,14 +27,12 @@ end end device domain 0x0 on - device pci 00.0 on # Host bridge Host bridge - subsystemid 0x17aa 0x2205 - end - device pci 01.0 off # PCIe Bridge for discrete graphics - end - device pci 02.0 on # Internal graphics VGA controller - subsystemid 0x17aa 0x2205 - end + subsystemid 0x17aa 0x2205 inherit + + device pci 00.0 on end # Host bridge Host bridge + device pci 01.0 off end # PCIe Bridge for discrete graphics + device pci 02.0 on end # Internal graphics VGA controller + chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH register "c2_latency" = "0x0065" register "docking_supported" = "1" @@ -55,83 +53,44 @@ register "spi_uvscc" = "0x2005" register "spi_lvscc" = "0x2005"
- device pci 14.0 on # USB 3.0 Controller - subsystemid 0x17aa 0x2205 - end - device pci 16.0 off # Management Engine Interface 1 - end - device pci 16.1 off # Management Engine Interface 2 - end - device pci 16.2 off # Management Engine IDE-R - end - device pci 16.3 off # Management Engine KT - end - device pci 19.0 off # Intel Gigabit Ethernet - end - device pci 1a.0 on # USB2 EHCI #2 - subsystemid 0x17aa 0x2205 - end - device pci 1b.0 on # High Definition Audio Audio controller - subsystemid 0x17aa 0x2205 - end - device pci 1c.0 on # PCIe Port #1 - subsystemid 0x17aa 0x2205 - end - device pci 1c.1 on # PCIe Port #2 - subsystemid 0x17aa 0x2205 - end - device pci 1c.2 off # PCIe Port #3 - end - device pci 1c.3 on # PCIe Port #4 - subsystemid 0x17aa 0x2205 - end - device pci 1c.4 off # PCIe Port #5 - end - device pci 1c.5 off # PCIe Port #6 - end - device pci 1c.6 off # PCIe Port #7 - end - device pci 1c.7 off # PCIe Port #8 - end - device pci 1d.0 on # USB2 EHCI #1 - subsystemid 0x17aa 0x2205 - end - device pci 1e.0 off # PCI bridge - end + device pci 14.0 on end # USB 3.0 Controller + device pci 16.0 off end # Management Engine Interface 1 + device pci 16.1 off end # Management Engine Interface 2 + device pci 16.2 off end # Management Engine IDE-R + device pci 16.3 off end # Management Engine KT + device pci 19.0 off end # Intel Gigabit Ethernet + device pci 1a.0 on end # USB2 EHCI #2 + device pci 1b.0 on end # High Definition Audio Audio controller + device pci 1c.0 on end # PCIe Port #1 + device pci 1c.1 on end # PCIe Port #2 + device pci 1c.2 off end # PCIe Port #3 + device pci 1c.3 on end # PCIe Port #4 + device pci 1c.4 off end # PCIe Port #5 + device pci 1c.5 off end # PCIe Port #6 + device pci 1c.6 off end # PCIe Port #7 + device pci 1c.7 off end # PCIe Port #8 + device pci 1d.0 on end # USB2 EHCI #1 + device pci 1e.0 off end # PCI bridge device pci 1f.0 on # LPC bridge PCI-LPC bridge - subsystemid 0x17aa 0x2205 chip drivers/pc80/tpm device pnp 0c31.0 on end end end - device pci 1f.2 on # SATA Controller 1 - subsystemid 0x17aa 0x2205 - end + device pci 1f.2 on end # SATA Controller 1 device pci 1f.3 on # SMBus - subsystemid 0x17aa 0x2205 chip drivers/i2c/at24rf08c # eeprom, 8 virtual devices, same chip - device i2c 54 on - end - device i2c 55 on - end - device i2c 56 on - end - device i2c 57 on - end - device i2c 5c on - end - device i2c 5d on - end - device i2c 5e on - end - device i2c 5f on - end + device i2c 54 on end + device i2c 55 on end + device i2c 56 on end + device i2c 57 on end + device i2c 5c on end + device i2c 5d on end + device i2c 5e on end + device i2c 5f on end end end - device pci 1f.5 off # SATA Controller 2 - end - device pci 1f.6 off # Thermal - end + device pci 1f.5 off end # SATA Controller 2 + device pci 1f.6 off end # Thermal end end end
-
HAOUAS Elyes (Code Review) -
Patrick Georgi (Code Review)
-
Peter Lemenkov (Code Review)