Attention is currently required from: Jason Glenesk, Martin L Roth, Paul Menzel, Angel Pons, Elyes Haouas.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73792 )
Change subject: crossgcc: Upgrade LLVM version 15.0.7 to 16.0.1
......................................................................
Patch Set 11:
(1 comment)
File util/crossgcc/buildgcc:
https://review.coreboot.org/c/coreboot/+/73792/comment/5dba22e9_d01eb2d2
PS11, Line 887: cd "$DESTDIR$TARGETDIR/lib/clang/${CLANG_VERSION}/lib" || exit 1
I investigated the build failure and this is the reason. CLANG_VERSION is 16.0. […]
Not sure if that's a LLVM versioning issue. On our side, we could change the line to this but also not sure if that's more a hack.
`cd "$DESTDIR$TARGETDIR/lib/clang/*/lib" || exit 1`
This makes cd using whatever is there. Since the XGCC folder is always specific to one toolchain version, thus it shouldn't contain multiple versions of Clang, there should always be just one folder.
Opinions?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73792
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I753bbcf3f03907b0cf966454c3dd6c9b61869599
Gerrit-Change-Number: 73792
Gerrit-PatchSet: 11
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Tue, 18 Apr 2023 01:32:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-MessageType: comment