Hello Edward O'Callaghan,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/37701
to review the following change.
Change subject: mainboard/google/puff: Avoid vboot early ec sync ......................................................................
mainboard/google/puff: Avoid vboot early ec sync
Puff's EC doesn't really support the 'EC_CMD_CHARGE_STATE' cmd because it doesn't have a charger IC on the board.
BRANCH=none BUG=b:146165519 TEST=./util/abuild/abuild -p none -t google/hatch -x -a
Change-Id: I1d396e164be38639095a0e6dd0602c6b11bf8eb2 Signed-off-by: Edward O'Callaghan quasisec@google.com --- M src/mainboard/google/hatch/Kconfig 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/37701/1
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 98a0174..1904e41 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -127,6 +127,11 @@ config VBOOT select HAS_RECOVERY_MRC_CACHE select MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN + +config VBOOT_LAPTOP + bool + default y if !BOARD_GOOGLE_PUFF + depends on VBOOT select VBOOT_EARLY_EC_SYNC select VBOOT_LID_SWITCH
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37701 )
Change subject: mainboard/google/puff: Avoid vboot early ec sync ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37701/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/37701/1/src/mainboard/google/hatch/... PS1, Line 131: VBOOT_LAPTOP If Puff isn't a laptop, then I guess it shouldn't select SYSTEM_TYPE_LAPTOP above?
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37701 )
Change subject: mainboard/google/puff: Avoid vboot early ec sync ......................................................................
Patch Set 1: Code-Review-2
Edward O'Callaghan has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37701 )
Change subject: mainboard/google/puff: Avoid vboot early ec sync ......................................................................
Abandoned
no longer needed