Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52184 )
Change subject: soc/amd/cezanne: Add GRXS and GTXS method
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
We can add Kconfig CONFIG_SOC_AMD_COMMON_BLOCK_ACPI_GPIO in makefile :p
yep, that's the general direction i was thinking of. it'll probably end up being similar to what i did for the common psp support where stoneyridge was also a bit different to picasso/cezanne
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52184
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2e3512562f92de230cf2e6967ec90527fb3d62ee
Gerrit-Change-Number: 52184
Gerrit-PatchSet: 1
Gerrit-Owner: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Fri, 09 Apr 2021 13:52:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mathew King
mathewk@chromium.org
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment