build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27813 )
Change subject: soc/amd/stoneyridge: Enable spread spectrum in bootblock ......................................................................
Patch Set 2:
(6 comments)
https://review.coreboot.org/#/c/27813/2/src/soc/amd/stoneyridge/include/soc/... File src/soc/amd/stoneyridge/include/soc/southbridge.h:
https://review.coreboot.org/#/c/27813/2/src/soc/amd/stoneyridge/include/soc/... PS2, Line 380: #define CG1PLL_SS_STEP_SIZE_DSFRAC_MASK (0xFFFF << CG1PLL_SS_STEP_SIZE_DSFRAC_SHIFT) line over 80 characters
https://review.coreboot.org/#/c/27813/2/src/soc/amd/stoneyridge/include/soc/... PS2, Line 382: #define CG1PLL_SS_AMOUNT_DSFRAC_MASK (0xFFFF << CG1PLL_SS_AMOUNT_DSFRAC_SHIFT) line over 80 characters
https://review.coreboot.org/#/c/27813/2/src/soc/amd/stoneyridge/include/soc/... PS2, Line 385: #define CG1PLL_SS_AMOUNT_NFRAC_SLIP_MASK (0xF << CG1PLL_SS_AMOUNT_NFRAC_SLIP_SHIFT) line over 80 characters
https://review.coreboot.org/#/c/27813/2/src/soc/amd/stoneyridge/southbridge.... File src/soc/amd/stoneyridge/southbridge.c:
https://review.coreboot.org/#/c/27813/2/src/soc/amd/stoneyridge/southbridge.... PS2, Line 579: cfg5 |= (0x2 << CG1PLL_SS_AMOUNT_NFRAC_SLIP_SHIFT) & CG1PLL_SS_AMOUNT_NFRAC_SLIP_MASK; line over 80 characters
https://review.coreboot.org/#/c/27813/2/src/soc/amd/stoneyridge/southbridge.... PS2, Line 584: cfg4 |= (0xD000 << CG1PLL_SS_AMOUNT_DSFRAC_SHIFT) & CG1PLL_SS_AMOUNT_DSFRAC_MASK; line over 80 characters
https://review.coreboot.org/#/c/27813/2/src/soc/amd/stoneyridge/southbridge.... PS2, Line 586: cfg4 |= (0x02D5 << CG1PLL_SS_STEP_SIZE_DSFRAC_SHIFT) & CG1PLL_SS_STEP_SIZE_DSFRAC_MASK; line over 80 characters
-
build bot (Jenkins) (Code Review)