Attention is currently required from: Nicholas Chin, Paul Menzel.
Jan Philipp Groß has posted comments on this change by Jan Philipp Groß. ( https://review.coreboot.org/c/coreboot/+/86007?usp=email )
Change subject: mb/asrock/fatal1ty_z87_professional: List another USB debug port
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/asrock/fatal1ty_z87_professional/Kconfig:
https://review.coreboot.org/c/coreboot/+/86007/comment/93b7edd4_f7cc0749?usp... :
PS3, Line 25:
No tab necessary? Just one space?
This was done to be in-line with the formatting on my other ports. Usually there are two lines (one for rear port, one for headers). The tab makes it easier to read in that case. See this for example:
https://review.coreboot.org/c/coreboot/+/84672/11/src/mainboard/asrock/z87_e...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86007?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia2bfb8ff2fbfab426c569198466cc27b83a85bc7
Gerrit-Change-Number: 86007
Gerrit-PatchSet: 3
Gerrit-Owner: Jan Philipp Groß
jeangrande@mailbox.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Comment-Date: Thu, 16 Jan 2025 13:36:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org