Attention is currently required from: Shaunak Saha, Caveh Jalali, Duncan Laurie, Nick Vaccaro, Patrick Rudolph.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50870 )
Change subject: intel/tigerlake: Add Acoustic features
......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50870/comment/8b3e0985_8166bafa
PS2, Line 9: Expose the following FSP UPD interface into coreboot:
: - AcousticNoiseMitigation
: - FastPkgCRampDisable
: - SlowSlewRateFo
Will fix.
Done
File src/soc/intel/tigerlake/chip.h:
https://review.coreboot.org/c/coreboot/+/50870/comment/f2f53202_343ace8d
PS2, Line 187: VR domain
Will Fix
Done
https://review.coreboot.org/c/coreboot/+/50870/comment/10993339_0a6dfa5a
PS2, Line 193: FastPkgCRampDisable
Correct.
Done
https://review.coreboot.org/c/coreboot/+/50870/comment/f81f300f_43731379
PS2, Line 197: VR domain
Will Fix.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50870
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica7f1f29995df33bdebb1fd55169cdb36f329ff8
Gerrit-Change-Number: 50870
Gerrit-PatchSet: 4
Gerrit-Owner: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
duncan@iceblink.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Duncan Laurie
duncan@iceblink.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 06 Apr 2021 23:28:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shaunak Saha
shaunak.saha@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment