[S] Change in coreboot[master]: soc/intel/common: Use 'enum cb_err' values

[Martin L Roth (Code Review)]

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/71824 )

Change subject: soc/intel/common: Use 'enum cb_err' values
......................................................................

soc/intel/common: Use 'enum cb_err' values

The patch uses cb_err enum values as return values for function
cse_get_boot_performance_data() instead of true/false.

TEST=Build code for Gimble

Signed-off-by: Sridhar Siricilla 
Change-Id: I0153d5496c96fb0c2a576eef1fe2fa7fa0db8415
Reviewed-on: https://review.coreboot.org/c/coreboot/+/71824
Tested-by: build bot (Jenkins) 
Reviewed-by: Eric Lai 
---
M src/soc/intel/common/block/cse/cse_lite.c
M src/soc/intel/common/block/cse/telemetry.c
M src/soc/intel/common/block/include/intelblocks/cse.h
3 files changed, 24 insertions(+), 6 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Eric Lai: Looks good to me, approved

diff --git a/src/soc/intel/common/block/cse/cse_lite.c b/src/soc/intel/common/block/cse/cse_lite.c
index 08a3d1f..c4ca41b 100644
--- a/src/soc/intel/common/block/cse/cse_lite.c
+++ b/src/soc/intel/common/block/cse/cse_lite.c
@@ -156,7 +156,7 @@
    	printk(BIOS_ERR, "ME: Write protection for CSE RO is not enabled\n");
 }

-bool cse_get_boot_performance_data(struct cse_boot_perf_rsp *boot_perf_rsp)
+enum cb_err cse_get_boot_performance_data(struct cse_boot_perf_rsp *boot_perf_rsp)
 {
    struct cse_boot_perf_req {
    	struct mkhi_hdr hdr;
@@ -174,16 +174,16 @@
    if (heci_send_receive(&req, sizeof(req), boot_perf_rsp, &resp_size,
    								HECI_MKHI_ADDR)) {
    	printk(BIOS_ERR, "cse_lite: Could not get boot performance data\n");
-		return false;
+		return CB_ERR;
    }

if (boot_perf_rsp->hdr.result) {
    	printk(BIOS_ERR, "cse_lite: Get boot performance data resp failed: %d\n",
    			boot_perf_rsp->hdr.result);
-		return false;
+		return CB_ERR;
    }

-	return true;
+	return CB_SUCCESS;
 }

diff --git a/src/soc/intel/common/block/cse/telemetry.c b/src/soc/intel/common/block/cse/telemetry.c
index f3dd7ee..5f36360 100644
--- a/src/soc/intel/common/block/cse/telemetry.c
+++ b/src/soc/intel/common/block/cse/telemetry.c
@@ -22,7 +22,7 @@
     * 4. All other TS values will be relative to the zero point. The API caller should
     *    normalize the TS values to the zero-point value.
     */
-	if (!cse_get_boot_performance_data(&cse_perf_data))
+	if (cse_get_boot_performance_data(&cse_perf_data) != CB_SUCCESS)
    	return;

current_time = timestamp_get();
diff --git a/src/soc/intel/common/block/include/intelblocks/cse.h b/src/soc/intel/common/block/include/intelblocks/cse.h
index 356df05..422f69c 100644
--- a/src/soc/intel/common/block/include/intelblocks/cse.h
+++ b/src/soc/intel/common/block/include/intelblocks/cse.h
@@ -524,7 +524,7 @@
  * This command retrieves a set of boot performance timestamps CSME collected during
  * the last platform boot flow.
  */
-bool cse_get_boot_performance_data(struct cse_boot_perf_rsp *boot_perf);
+enum cb_err cse_get_boot_performance_data(struct cse_boot_perf_rsp *boot_perf);

/* Function to make cse disable using PMC IPC */
 bool cse_disable_mei_devices(void);