Attention is currently required from: Angel Pons, Arthur Heymans, Felix Held, Felix Singer, Jérémy Compostella, Paul Menzel, yuchi.chen@intel.com.
Lean Sheng Tan has posted comments on this change by yuchi.chen@intel.com. ( https://review.coreboot.org/c/coreboot/+/83318?usp=email )
Change subject: soc/intel/common/systemagent_server: Add server platform system agent
......................................................................
Patch Set 29:
(3 comments)
Patchset:
PS19:
I've implemented a basic version of server system agent, you can review now.
Any response @th3fanbus@gmail.com? If not will proceed to resolve this comment by this week, thanks :)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83318/comment/161b4d47_e40309f7?usp... :
PS13, Line 9: System agent in Intel common block (1) assumes TOLUD and TOUUD
: registers hold the max available address plus 1, but on some SoC like
: Snow Ridge, it holds the max available address; (2) aligns TOLUD, TOUUD
: and TSEG registers to 1 MiB default, but some SoC may have different
: alignments. This patch add a new weak function
: `soc_systemagent_fixup_address()` to improve it.
Now I'm using a new Kconfig item SA_FIXUP_ADDRESS to select if SoC need to fixup the address base an […]
Acknowledged
Commit Message:
https://review.coreboot.org/c/coreboot/+/83318/comment/31782979_d059ea3d?usp... :
PS19, Line 10: but on some SoC like
: Snow Ridge, it holds the max available address
No, and there's no reason to do run-time detection: the problems arise from trying to reuse common c […]
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83318?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If32c2a6524c9d55ce7f9c3dd203bcf85cab76c2c
Gerrit-Change-Number: 83318
Gerrit-PatchSet: 29
Gerrit-Owner: yuchi.chen@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Vasiliy Khoruzhick
vasilykh@arista.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: yuchi.chen@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 07 Nov 2024 05:17:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: yuchi.chen@intel.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz