Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35508 )
Change subject: HACK trogdor: SoC makefile BLOB support HACK ......................................................................
Patch Set 81:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35508/78/src/soc/qualcomm/sc7180/Ma... File src/soc/qualcomm/sc7180/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35508/78/src/soc/qualcomm/sc7180/Ma... PS78, Line 79: SC7180_BLOB := $(top)/3rdparty/blobs/soc/qualcomm/sc7180 Now that CB:42548 has landed, please rewrite this to access $(top)/3rdparty/qc_blobs instead and take this patch out of HACK status (meaning we shouldn't have the check for whether the file exists anymore either). You should also add a 'depends on USE_QC_BLOBS' to all boards in src/mainboard/google/trogdor/Kconfig.name.
-
Julius Werner (Code Review)