Attention is currently required from: Angel Pons, Arthur Heymans, Benjamin Doron, Christian Walter, Lean Sheng Tan, Leon Groß, Patrick Rudolph, Paul Menzel.
Leon Groß has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77905?usp=email )
Change subject: mb/emulation: Add SIMICS QSP support ......................................................................
Patch Set 11:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/77905/comment/b91e7624_396758e8 : PS9, Line 9: SIMICS QSP
Quick Start Platfrom (QSP)
Done
https://review.coreboot.org/c/coreboot/+/77905/comment/f8a313f1_b0a163dc : PS9, Line 20:
Please paste the commands you use, and document the versions you tested with.
Can you specify what you mean with 'the commands you used' and which versions I should provide?
File src/mainboard/emulation/simics-qsp/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/77905/comment/2e69c490_58477f4e : PS4, Line 365: /**************************************************************** : * General purpose events : ****************************************************************/ : : Scope(_GPE) { : Name(_HID, "ACPI0006") : : Method(_L00) { : } : Method(_L01) { : } : Method(_L02) { : } : Method(_L03) { : } : Method(_L04) { : } : Method(_L05) { : } : Method(_L06) { : } : Method(_L07) { : } : Method(_L08) { : } : Method(_L09) { : } : Method(_L0A) { : } : Method(_L0B) { : } : Method(_L0C) { : } : Method(_L0D) { : } : Method(_L0E) { : } : Method(_L0F) { : } : }
I'm not an expert on ACPI, but I thought in other
Done
-
Leon Groß (Code Review)