Attention is currently required from: Hung-Te Lin, Paul Menzel, Ruihai Zhou, Xuxin Xiong, Yidi Lin, Yu-Ping Wu.
Yang Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81585?usp=email )
Change subject: mb/google/corsola/var/wugtrio: Enable the MIPI panel KD_KD101NE3_40TI
......................................................................
Patch Set 2:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81585/comment/aaa085cd_5caffb20 :
PS1, Line 7: for Wugtrio
Please put it into the prefix.
Done
File src/mainboard/google/corsola/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/81585/comment/093ebb3c_b5b78e80 :
PS1, Line 29:
remove blank line
Done
File src/mainboard/google/corsola/panel_wugtrio.c:
https://review.coreboot.org/c/coreboot/+/81585/comment/e7cf4323_d28b2bfb :
PS1, Line 15:
remove blank line
Done
https://review.coreboot.org/c/coreboot/+/81585/comment/aaae0f65_f45316f2 :
PS1, Line 23: mdelay(15);
Is that mentioned in the spec?
Yes,it is based on the power on sequence of the spec KD101NE3-40TI-A003 _Pre SPEC_20231218.pdf
https://review.coreboot.org/c/coreboot/+/81585/comment/49ef9832_008856f5 :
PS1, Line 30: KingDisplay
K&D Technology […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81585?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I586de68da4d0ee2dd5b7baea92ebb06db9fcfe8b
Gerrit-Change-Number: 81585
Gerrit-PatchSet: 2
Gerrit-Owner: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-Reviewer: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-Attention: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Sun, 31 Mar 2024 11:36:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Yidi Lin
yidilin@google.com
Gerrit-MessageType: comment