Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39946 )
Change subject: mb/google/beltino: drop ACPI brightness control stub ......................................................................
mb/google/beltino: drop ACPI brightness control stub
beltino variants are Chromeboxes without built-in displays, so now that default_brightness_levels.asl is no longer required for all boards in a platform, drop it.
Change-Id: Ie8147763fc9fdf4f184d3d000bffd6794e134d9e Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/beltino/dsdt.asl 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/39946/1
diff --git a/src/mainboard/google/beltino/dsdt.asl b/src/mainboard/google/beltino/dsdt.asl index f494d2f..da11fed 100644 --- a/src/mainboard/google/beltino/dsdt.asl +++ b/src/mainboard/google/beltino/dsdt.asl @@ -38,8 +38,6 @@ { #include <northbridge/intel/haswell/acpi/haswell.asl> #include <southbridge/intel/lynxpoint/acpi/pch.asl> - - #include <drivers/intel/gma/acpi/default_brightness_levels.asl> } }
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39946 )
Change subject: mb/google/beltino: drop ACPI brightness control stub ......................................................................
Patch Set 5: Code-Review+2
Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39946 )
Change subject: mb/google/beltino: drop ACPI brightness control stub ......................................................................
mb/google/beltino: drop ACPI brightness control stub
beltino variants are Chromeboxes without built-in displays, so now that default_brightness_levels.asl is no longer required for all boards in a platform, drop it.
Change-Id: Ie8147763fc9fdf4f184d3d000bffd6794e134d9e Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39946 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/beltino/dsdt.asl 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/google/beltino/dsdt.asl b/src/mainboard/google/beltino/dsdt.asl index f494d2f..da11fed 100644 --- a/src/mainboard/google/beltino/dsdt.asl +++ b/src/mainboard/google/beltino/dsdt.asl @@ -38,8 +38,6 @@ { #include <northbridge/intel/haswell/acpi/haswell.asl> #include <southbridge/intel/lynxpoint/acpi/pch.asl> - - #include <drivers/intel/gma/acpi/default_brightness_levels.asl> } }
-
Angel Pons (Code Review) -
Matt DeVillier (Code Review)