Change in coreboot[master]: mbgizmosphere/gizmo/mainboard.c: Remove white space after 'mdelay'
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44094 )
Change subject: mbgizmosphere/gizmo/mainboard.c: Remove white space after 'mdelay' ......................................................................
mbgizmosphere/gizmo/mainboard.c: Remove white space after 'mdelay'
Change-Id: Ib7c6ab0a2e5a03f30b70c4bbb1091fa9c689c23b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/gizmosphere/gizmo/mainboard.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/44094/1
diff --git a/src/mainboard/gizmosphere/gizmo/mainboard.c b/src/mainboard/gizmosphere/gizmo/mainboard.c index 8046be6..f24c9e9 100644 --- a/src/mainboard/gizmosphere/gizmo/mainboard.c +++ b/src/mainboard/gizmosphere/gizmo/mainboard.c @@ -40,7 +40,7 @@ ABAR &= 0xFFFFFC00; memptr = (u8 *)(ABAR + 0x100 + 0x80 + 0x2C); /* we're on the 2nd port */ *memptr = 0x21; /* force to GEN2 and start re-negotiate */ - mdelay (1); + mdelay(1); *memptr = 0x20; }
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44094 )
Change subject: mbgizmosphere/gizmo/mainboard.c: Remove white space after 'mdelay' ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44094/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44094/1//COMMIT_MSG@7 PS1, Line 7: mbgizmosphere mb/
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44094
to look at the new patch set (#2).
Change subject: mb/gizmosphere/gizmo/mainboard.c: Remove white space after 'mdelay' ......................................................................
mb/gizmosphere/gizmo/mainboard.c: Remove white space after 'mdelay'
Change-Id: Ib7c6ab0a2e5a03f30b70c4bbb1091fa9c689c23b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/gizmosphere/gizmo/mainboard.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/44094/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44094 )
Change subject: mb/gizmosphere/gizmo/mainboard.c: Remove white space after 'mdelay' ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44094/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44094/1//COMMIT_MSG@7 PS1, Line 7: mbgizmosphere
mb/
Thx
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44094 )
Change subject: mb/gizmosphere/gizmo/mainboard.c: Remove white space after 'mdelay' ......................................................................
Patch Set 2: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44094 )
Change subject: mb/gizmosphere/gizmo/mainboard.c: Remove white space after 'mdelay' ......................................................................
mb/gizmosphere/gizmo/mainboard.c: Remove white space after 'mdelay'
Change-Id: Ib7c6ab0a2e5a03f30b70c4bbb1091fa9c689c23b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/44094 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/gizmosphere/gizmo/mainboard.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/gizmosphere/gizmo/mainboard.c b/src/mainboard/gizmosphere/gizmo/mainboard.c index 8046be6..f24c9e9 100644 --- a/src/mainboard/gizmosphere/gizmo/mainboard.c +++ b/src/mainboard/gizmosphere/gizmo/mainboard.c @@ -40,7 +40,7 @@ ABAR &= 0xFFFFFC00; memptr = (u8 *)(ABAR + 0x100 + 0x80 + 0x2C); /* we're on the 2nd port */ *memptr = 0x21; /* force to GEN2 and start re-negotiate */ - mdelay (1); + mdelay(1); *memptr = 0x20; }
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Paul Menzel (Code Review)