Change in ...coreboot[master]: arch/x86: Make X86 specific options depend on ARCH_X86 - coreboot-gerrit

15 Jun 2019


      Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31316 )
Change subject: arch/x86: Make X86 specific options depend on ARCH_X86
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/31316/5/src/mainboard/packardbell/ms2290/Kco... 
File src/mainboard/packardbell/ms2290/Kconfig:
https://review.coreboot.org/#/c/31316/5/src/mainboard/packardbell/ms2290/Kco... 
PS5, Line 6: 	select ARCH_X86
           : 	select ARCH_BOOTBLOCK_X86_32
           : 	select ARCH_ROMSTAGE_X86_32
           : 	select ARCH_RAMSTAGE_X86_32
Shouldn't these be selected by the northbridge/CPU?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/31316
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic77b696f493d7648f317f0ba0a27fdee5212961e
Gerrit-Change-Number: 31316
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: David Guckian david.guckian@intel.com
Gerrit-Reviewer: Huang Jin huang.jin@intel.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: Vanny E vanessa.f.eusebio@intel.com
Gerrit-Reviewer: York Yang yyang024@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 15 Jun 2019 16:51:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment