Attention is currently required from: Shelley Chen, Ravi kumar. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52371 )
Change subject: sc7280: Add GSI FW download support ......................................................................
Patch Set 19:
(11 comments)
File src/soc/qualcomm/sc7280/include/soc/qupv3_config.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121771): https://review.coreboot.org/c/coreboot/+/52371/comment/176b4f1a_9034fe99 PS19, Line 77: { open brace '{' following struct go on the same line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121771): https://review.coreboot.org/c/coreboot/+/52371/comment/de637122_34c1745d PS19, Line 79: uint32_t iram_dword1; /* word 1 of a single IRAM firmware entry */ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121771): https://review.coreboot.org/c/coreboot/+/52371/comment/e29f9d01_8d1308d1 PS19, Line 83: { open brace '{' following struct go on the same line
File src/soc/qualcomm/sc7280/qupv3_config.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121771): https://review.coreboot.org/c/coreboot/+/52371/comment/9a57f388_3c8d0843 PS19, Line 204: write32(®s->gsi_periph_base_lsb,0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121771): https://review.coreboot.org/c/coreboot/+/52371/comment/d7786ba2_c2109658 PS19, Line 205: write32(®s->gsi_periph_base_msb,0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121771): https://review.coreboot.org/c/coreboot/+/52371/comment/5d7bed13_56147202 PS19, Line 210: if (fwIep[i].offset < GSI_REG_BASE_SIZE) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121771): https://review.coreboot.org/c/coreboot/+/52371/comment/36a9dbac_bd273ca9 PS19, Line 221: memcpy((®s->gsi_inst_ramn),(void *)fwIRam, space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121771): https://review.coreboot.org/c/coreboot/+/52371/comment/cf868beb_63b258ca PS19, Line 223: setbits_le32(®s->gsi_mcs_cfg, GSI_MCS_CFG_MCS_ENABLE_BMSK ); space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121771): https://review.coreboot.org/c/coreboot/+/52371/comment/19f4efce_57bf47de PS19, Line 224: setbits_le32(®s->gsi_cfg, GSI_CFG_DOUBLE_MCS_CLK_FREQ_BMSK | GSI_CFG_GSI_ENABLE_BMSK); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121771): https://review.coreboot.org/c/coreboot/+/52371/comment/7aaac4b4_c5047681 PS19, Line 226: write32(®s->gsi_ee_n_scratch_0_addr,0x0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121771): https://review.coreboot.org/c/coreboot/+/52371/comment/f54e5b13_7d6c3100 PS19, Line 227: write32(®s->ee_n_gsi_ee_generic_cmd,0x81); space required after that ',' (ctx:VxV)
-
build bot (Jenkins) (Code Review)