Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/18548 )
Change subject: nb/intel/i945: Programm CxODT value for each channel ......................................................................
Patch Set 26:
(2 comments)
https://review.coreboot.org/c/coreboot/+/18548/22/src/northbridge/intel/i945... File src/northbridge/intel/i945/raminit.c:
https://review.coreboot.org/c/coreboot/+/18548/22/src/northbridge/intel/i945... PS22, Line 2463: (dimm_mask & 3) != 3
if both are not populated, the condition is true and we will assume that one DIMM is populated
Let's move this to the newest patch set because the code looks different by now.
https://review.coreboot.org/c/coreboot/+/18548/26/src/northbridge/intel/i945... File src/northbridge/intel/i945/raminit.c:
https://review.coreboot.org/c/coreboot/+/18548/26/src/northbridge/intel/i945... PS26, Line 2445: if (!(sysinfo->dimm[0] != SYSINFO_DIMM_NOT_POPULATED && From Nico's comment in PS22: It can be written even clearer by pulling the outer ! in:
if (sysinfo->dimm[0] == SYSINFO_DIMM_NOT_POPULATED || sysinfo->dimm[1] == SYSINFO_DIMM_NOT_POPULATED)
That statement is identical (see DeMorgan's law) but avoids the double-negation.
-
Patrick Georgi (Code Review)