EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36501 )
Change subject: mb/google/drallion: Add second touch pad support ......................................................................
mb/google/drallion: Add second touch pad support
Add second source touch pad with i2c address 0x15.
BUG=b:142629138 BRANCH=N/A TEST=check new touch pad can work properly
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Icc58dbcf307f11c368a1a5408f32111ed5841d39 --- M src/mainboard/google/drallion/variants/drallion/devicetree.cb 1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/36501/1
diff --git a/src/mainboard/google/drallion/variants/drallion/devicetree.cb b/src/mainboard/google/drallion/variants/drallion/devicetree.cb index 1f628d6..0de2e94 100644 --- a/src/mainboard/google/drallion/variants/drallion/devicetree.cb +++ b/src/mainboard/google/drallion/variants/drallion/devicetree.cb @@ -373,6 +373,13 @@ register "probed" = "1" device i2c 2c on end end + chip drivers/i2c/generic + register "hid" = ""ELAN0000"" + register "desc" = ""ELAN Touchpad"" + register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_B3_IRQ)" + register "probed" = "1" + device i2c 15 on end + end end # I2C #1 device pci 15.2 off end # I2C #2 device pci 15.3 off end # I2C #3
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36501 )
Change subject: mb/google/drallion: Add second touch pad support ......................................................................
Patch Set 1:
Verified Pass at my side.
Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36501 )
Change subject: mb/google/drallion: Add second touch pad support ......................................................................
Patch Set 1: Code-Review+2
Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36501 )
Change subject: mb/google/drallion: Add second touch pad support ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36501 )
Change subject: mb/google/drallion: Add second touch pad support ......................................................................
mb/google/drallion: Add second touch pad support
Add second source touch pad with i2c address 0x15.
BUG=b:142629138 BRANCH=N/A TEST=check new touch pad can work properly
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Icc58dbcf307f11c368a1a5408f32111ed5841d39 Reviewed-on: https://review.coreboot.org/c/coreboot/+/36501 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Ivy Jian ivy_jian@compal.corp-partner.google.com Reviewed-by: Mathew King mathewk@chromium.org --- M src/mainboard/google/drallion/variants/drallion/devicetree.cb 1 file changed, 7 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Ivy Jian: Looks good to me, approved Mathew King: Looks good to me, approved
diff --git a/src/mainboard/google/drallion/variants/drallion/devicetree.cb b/src/mainboard/google/drallion/variants/drallion/devicetree.cb index 1f628d6..0de2e94 100644 --- a/src/mainboard/google/drallion/variants/drallion/devicetree.cb +++ b/src/mainboard/google/drallion/variants/drallion/devicetree.cb @@ -373,6 +373,13 @@ register "probed" = "1" device i2c 2c on end end + chip drivers/i2c/generic + register "hid" = ""ELAN0000"" + register "desc" = ""ELAN Touchpad"" + register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_B3_IRQ)" + register "probed" = "1" + device i2c 15 on end + end end # I2C #1 device pci 15.2 off end # I2C #2 device pci 15.3 off end # I2C #3
-
EricR Lai (Code Review) -
Ivy Jian (Code Review)
-
Mathew King (Code Review)
-
Patrick Georgi (Code Review)