Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48773 )
Change subject: soc/intel/*,mb/*: do not include boilerplate GFX0 device by default
......................................................................
Patch Set 13: -Code-Review
Patch Set 13:
Patch Set 12:
Patch Set 5: Code-Review-1
with CB:48862 we can include gma.asl now instead and drop the boilerplate version
Is this patch necessary for making libgfxinit on soc/intel/cannonlake working? If not, can you rebase this one on mb/clevo/l140cu so that these come first?
no, not required, I rebased this
ouch. I was wrong. This *is* required, since two GFX0 (one from southbridge.asl and one from gma.asl) will conflict... see buildbot fail in the l140cu patch
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48773
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I95a5a8f9cf54237614d83c5224ce6d37c6730dbb
Gerrit-Change-Number: 48773
Gerrit-PatchSet: 13
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 26 Dec 2020 20:14:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment