Change in coreboot[master]: amd/pi/hudson boards: Get rid of power button device

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Paul Menzel (Code Review)

27 Apr 2020 27 Apr '20

12:04 p.m.

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40753 )

Change subject: amd/pi/hudson boards: Get rid of power button device ......................................................................

amd/pi/hudson boards: Get rid of power button device

Port commit d7b88dcb (mb/google/x86-boards: Get rid of power button device in coreboot) to AMD AGESA Hudson boards (SOUTHBRIDGE_AMD_PI_AVALON).

Change-Id: Ibeec73c15f2282f7ab0be88f96693bcb551b3e45 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M src/mainboard/bap/ode_e21XX/dsdt.asl M src/mainboard/pcengines/apu2/dsdt.asl 2 files changed, 0 insertions(+), 14 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/40753/1

diff --git a/src/mainboard/bap/ode_e21XX/dsdt.asl b/src/mainboard/bap/ode_e21XX/dsdt.asl index f18550a..e604a5a 100644 --- a/src/mainboard/bap/ode_e21XX/dsdt.asl +++ b/src/mainboard/bap/ode_e21XX/dsdt.asl @@ -40,13 +40,6 @@ /* Describe IRQ Routing mapping for this platform (within the _SB scope) */ #include "acpi/routing.asl"

- Device(PWRB) { - Name(_HID, EISAID("PNP0C0C")) - Name(_UID, 0xAA) - Name(_PRW, Package () {3, 0x04}) - Name(_STA, 0x0B) - } - Device(PCI0) { /* Describe the AMD Northbridge */ #include <northbridge/amd/pi/00730F01/acpi/northbridge.asl> diff --git a/src/mainboard/pcengines/apu2/dsdt.asl b/src/mainboard/pcengines/apu2/dsdt.asl index cc6c03d..9ef1dd3 100644 --- a/src/mainboard/pcengines/apu2/dsdt.asl +++ b/src/mainboard/pcengines/apu2/dsdt.asl @@ -40,13 +40,6 @@ /* Describe IRQ Routing mapping for this platform (within the _SB scope) */ #include "acpi/routing.asl"

Attachments:

attachment.htm (text/html — 4.1 KB)

Show replies by date

Paul Menzel (Code Review)

3 May 3 May

9:53 p.m.

Hello build bot (Jenkins), Michał Żygowski, Piotr Król,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40753

to look at the new patch set (#2).

Change subject: amd/pi/hudson boards: Get rid of power button device ......................................................................

amd/pi/hudson boards: Get rid of power button device

Port commit d7b88dcb (mb/google/x86-boards: Get rid of power button device in coreboot) to AMD AGESA Hudson boards (SOUTHBRIDGE_AMD_PI_AVALON).

The GPE ACPI code seems to originate from commit 806def8c (I missed the svn add on r3787. These are the additional files., Add AMD dbm690t ACPI support.), and was copied over.

Change-Id: Ibeec73c15f2282f7ab0be88f96693bcb551b3e45 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M src/mainboard/bap/ode_e21XX/acpi/gpe.asl M src/mainboard/bap/ode_e21XX/dsdt.asl M src/mainboard/pcengines/apu2/acpi/gpe.asl M src/mainboard/pcengines/apu2/dsdt.asl 4 files changed, 1 insertion(+), 22 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/40753/2

build bot (Jenkins) (Code Review)

9:54 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40753 )

Change subject: amd/pi/hudson boards: Get rid of power button device ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40753/2/src/mainboard/pcengines/apu... File src/mainboard/pcengines/apu2/acpi/gpe.asl:

https://review.coreboot.org/c/coreboot/+/40753/2/src/mainboard/pcengines/apu... PS2, Line 51: trailing whitespace

-- To view, visit https://review.coreboot.org/c/coreboot/+/40753 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibeec73c15f2282f7ab0be88f96693bcb551b3e45 Gerrit-Change-Number: 40753 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Piotr Król piotr.krol@3mdeb.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 03 May 2020 21:54:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Menzel (Code Review)

10:06 p.m.

Hello build bot (Jenkins), Michał Żygowski, Piotr Król,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40753

to look at the new patch set (#3).

Change subject: amd/pi/hudson boards: Get rid of power button device ......................................................................

amd/pi/hudson boards: Get rid of power button device

Port commit d7b88dcb (mb/google/x86-boards: Get rid of power button device in coreboot) to AMD AGESA Hudson boards (SOUTHBRIDGE_AMD_PI_AVALON).

The GPE ACPI code seems to originate from commit 806def8c (I missed the svn add on r3787. These are the additional files., Add AMD dbm690t ACPI support.), and was copied over.

Change-Id: Ibeec73c15f2282f7ab0be88f96693bcb551b3e45 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M 3rdparty/intel-microcode M 3rdparty/vboot M src/mainboard/bap/ode_e21XX/acpi/gpe.asl M src/mainboard/bap/ode_e21XX/dsdt.asl M src/mainboard/pcengines/apu2/acpi/gpe.asl M src/mainboard/pcengines/apu2/dsdt.asl 6 files changed, 2 insertions(+), 23 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/40753/3

Paul Menzel (Code Review)

4 May 4 May

7:43 a.m.

Hello build bot (Jenkins), Michał Żygowski, Piotr Król,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40753

to look at the new patch set (#4).

Change subject: amd/pi/hudson boards: Get rid of power button device ......................................................................

amd/pi/hudson boards: Get rid of power button device

Port commit d7b88dcb (mb/google/x86-boards: Get rid of power button device in coreboot) to AMD AGESA Hudson boards (SOUTHBRIDGE_AMD_PI_AVALON).

The GPE ACPI code seems to originate from commit 806def8c (I missed the svn add on r3787. These are the additional files., Add AMD dbm690t ACPI support.), and was copied over.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/40753/4

Michał Żygowski (Code Review)

5 Jun 5 Jun

9:43 a.m.

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40753 )

Change subject: amd/pi/hudson boards: Get rid of power button device ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/40753 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibeec73c15f2282f7ab0be88f96693bcb551b3e45 Gerrit-Change-Number: 40753 Gerrit-PatchSet: 4 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Assignee: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Piotr Król piotr.krol@3mdeb.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 05 Jun 2020 09:43:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

6 Jun 6 Jun

9:44 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40753 )

Change subject: amd/pi/hudson boards: Get rid of power button device ......................................................................

amd/pi/hudson boards: Get rid of power button device

Port commit d7b88dcb (mb/google/x86-boards: Get rid of power button device in coreboot) to AMD AGESA Hudson boards (SOUTHBRIDGE_AMD_PI_AVALON).

The GPE ACPI code seems to originate from commit 806def8c (I missed the svn add on r3787. These are the additional files., Add AMD dbm690t ACPI support.), and was copied over.

Change-Id: Ibeec73c15f2282f7ab0be88f96693bcb551b3e45 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/40753 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michał Żygowski michal.zygowski@3mdeb.com --- M src/mainboard/bap/ode_e21XX/acpi/gpe.asl M src/mainboard/bap/ode_e21XX/dsdt.asl M src/mainboard/pcengines/apu2/acpi/gpe.asl M src/mainboard/pcengines/apu2/dsdt.asl 4 files changed, 0 insertions(+), 21 deletions(-)

Approvals: build bot (Jenkins): Verified Michał Żygowski: Looks good to me, approved

diff --git a/src/mainboard/bap/ode_e21XX/acpi/gpe.asl b/src/mainboard/bap/ode_e21XX/acpi/gpe.asl index 778c7f7..cdf1f05 100644 --- a/src/mainboard/bap/ode_e21XX/acpi/gpe.asl +++ b/src/mainboard/bap/ode_e21XX/acpi/gpe.asl @@ -5,7 +5,6 @@ /* General event 3 */ Method(_L03) { /* DBGO("\_GPE\_L00\n") */ - Notify(_SB.PWRB, 0x02) /* NOTIFY_DEVICE_WAKE */ }

/* Legacy PM event */ @@ -29,7 +28,6 @@ Notify(_SB.PCI0.UOH5, 0x02) /* NOTIFY_DEVICE_WAKE */ Notify(_SB.PCI0.UOH6, 0x02) /* NOTIFY_DEVICE_WAKE */ Notify(_SB.PCI0.XHC0, 0x02) /* NOTIFY_DEVICE_WAKE */ - Notify(_SB.PWRB, 0x02) /* NOTIFY_DEVICE_WAKE */ }

/* ExtEvent0 SCI event */ @@ -49,13 +47,11 @@ Notify(_SB.PCI0.PBR5, 0x02) /* NOTIFY_DEVICE_WAKE */ Notify(_SB.PCI0.PBR6, 0x02) /* NOTIFY_DEVICE_WAKE */ Notify(_SB.PCI0.PBR7, 0x02) /* NOTIFY_DEVICE_WAKE */ - Notify(_SB.PWRB, 0x02) /* NOTIFY_DEVICE_WAKE */ }

/* Azalia SCI event */ Method(_L1B) { /* DBGO("\_GPE\_L1B\n") */ Notify(_SB.PCI0.AZHD, 0x02) /* NOTIFY_DEVICE_WAKE */ - Notify(_SB.PWRB, 0x02) /* NOTIFY_DEVICE_WAKE */ } } /* End Scope GPE */ diff --git a/src/mainboard/bap/ode_e21XX/dsdt.asl b/src/mainboard/bap/ode_e21XX/dsdt.asl index fc71e14..5567cf3 100644 --- a/src/mainboard/bap/ode_e21XX/dsdt.asl +++ b/src/mainboard/bap/ode_e21XX/dsdt.asl @@ -39,13 +39,6 @@ /* Describe IRQ Routing mapping for this platform (within the _SB scope) */ #include "acpi/routing.asl"

- Device(PWRB) { - Name(_HID, EISAID("PNP0C0C")) - Name(_UID, 0xAA) - Name(_PRW, Package () {3, 0x04}) - Name(_STA, 0x0B) - } - Device(PCI0) { /* Describe the AMD Northbridge */ #include <northbridge/amd/pi/00730F01/acpi/northbridge.asl> diff --git a/src/mainboard/pcengines/apu2/acpi/gpe.asl b/src/mainboard/pcengines/apu2/acpi/gpe.asl index add1586..322e163 100644 --- a/src/mainboard/pcengines/apu2/acpi/gpe.asl +++ b/src/mainboard/pcengines/apu2/acpi/gpe.asl @@ -5,7 +5,6 @@ /* General event 3 */ Method(_L03) { /* DBGO("\_GPE\_L00\n") */ - Notify(_SB.PWRB, 0x02) /* NOTIFY_DEVICE_WAKE */ }

/* ExtEvent0 SCI event */ @@ -49,6 +47,5 @@ Notify(_SB.PCI0.PBR5, 0x02) /* NOTIFY_DEVICE_WAKE */ Notify(_SB.PCI0.PBR6, 0x02) /* NOTIFY_DEVICE_WAKE */ Notify(_SB.PCI0.PBR7, 0x02) /* NOTIFY_DEVICE_WAKE */ - Notify(_SB.PWRB, 0x02) /* NOTIFY_DEVICE_WAKE */ } } /* End Scope GPE */ diff --git a/src/mainboard/pcengines/apu2/dsdt.asl b/src/mainboard/pcengines/apu2/dsdt.asl index 4ee4fd8..e6543b9 100644 --- a/src/mainboard/pcengines/apu2/dsdt.asl +++ b/src/mainboard/pcengines/apu2/dsdt.asl @@ -39,13 +39,6 @@ /* Describe IRQ Routing mapping for this platform (within the _SB scope) */ #include "acpi/routing.asl"

-- To view, visit https://review.coreboot.org/c/coreboot/+/40753 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibeec73c15f2282f7ab0be88f96693bcb551b3e45 Gerrit-Change-Number: 40753 Gerrit-PatchSet: 5 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Assignee: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Piotr Król piotr.krol@3mdeb.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

9elements QA (Code Review)

7 Jun 7 Jun

5:37 p.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40753 )

Change subject: amd/pi/hudson boards: Get rid of power button device ......................................................................

Patch Set 5:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4998 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4997 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4996 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4995

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/40753 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibeec73c15f2282f7ab0be88f96693bcb551b3e45 Gerrit-Change-Number: 40753 Gerrit-PatchSet: 5 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Assignee: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Piotr Król piotr.krol@3mdeb.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-Comment-Date: Sun, 07 Jun 2020 17:37:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1440

days inactive

1481

days old

coreboot-gerrit@coreboot.org

7 comments

5 participants

tags (0)

participants (5)

9elements QA (Code Review)
build bot (Jenkins) (Code Review)
Michał Żygowski (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)