HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41686 )
Change subject: cpu/intel/haswell: Remove unused 'include <cpu/x86/bist.h>' ......................................................................
cpu/intel/haswell: Remove unused 'include <cpu/x86/bist.h>'
Change-Id: I5156eb97648927e5fe6e467abb8e3e055a231fec Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/intel/haswell/romstage.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/41686/1
diff --git a/src/cpu/intel/haswell/romstage.c b/src/cpu/intel/haswell/romstage.c index c682ef9..4b56301 100644 --- a/src/cpu/intel/haswell/romstage.c +++ b/src/cpu/intel/haswell/romstage.c @@ -2,7 +2,6 @@
#include <console/console.h> #include <cf9_reset.h> -#include <cpu/x86/bist.h> #include <timestamp.h> #include <cpu/x86/lapic.h> #include <cbmem.h>
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41686 )
Change subject: cpu/intel/haswell: Remove unused 'include <cpu/x86/bist.h>' ......................................................................
Patch Set 1: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41686 )
Change subject: cpu/intel/haswell: Remove unused 'include <cpu/x86/bist.h>' ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41686 )
Change subject: cpu/intel/haswell: Remove unused 'include <cpu/x86/bist.h>' ......................................................................
cpu/intel/haswell: Remove unused 'include <cpu/x86/bist.h>'
Change-Id: I5156eb97648927e5fe6e467abb8e3e055a231fec Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/41686 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/cpu/intel/haswell/romstage.c 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/src/cpu/intel/haswell/romstage.c b/src/cpu/intel/haswell/romstage.c index c682ef9..4b56301 100644 --- a/src/cpu/intel/haswell/romstage.c +++ b/src/cpu/intel/haswell/romstage.c @@ -2,7 +2,6 @@
#include <console/console.h> #include <cf9_reset.h> -#include <cpu/x86/bist.h> #include <timestamp.h> #include <cpu/x86/lapic.h> #include <cbmem.h>
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41686 )
Change subject: cpu/intel/haswell: Remove unused 'include <cpu/x86/bist.h>' ......................................................................
Patch Set 7:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/5004 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/5003 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/5002 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/5001
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)