Attention is currently required from: Shuming Chu (Shuming), Arthur Heymans, TangYiwei.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69222 )
Change subject: cpu/x86/topology: Add code to fill in topology on struct path ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File src/cpu/x86/topology.c:
https://review.coreboot.org/c/coreboot/+/69222/comment/648d8568_46678071 PS1, Line 33: if (cpuid_max_func >= CPUID_EXTENDED_CPU_TOPOLOGY) Should we print the failure and die() from the caller if CB_ERR is returned?
File src/include/cpu/x86/topology.h:
https://review.coreboot.org/c/coreboot/+/69222/comment/2bd74c00_32e4b512 PS1, Line 5: It would be good to add a comment here to explain what this function does.